The floating ip should be removed after shelve offload instance

Bug #1350704 reported by Alex Xu
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Alex Xu

Bug Description

Commit: 4f8185549dfe11eb1ce405711593baa1528045ea fixes the problem of update binding when unshelve instance for neutron. But that fixing didn't cover the case for nova-network. For nova-network with multi host, the floating ip should be removed when shelve offload instance.

produce as below:
1. nova boot vm1
2. iptables -t nat -L -n check the floating ip rules for vm1
3. nova shelve vm1
4. waiting for vm1 shelve offload
6. running iptables again, found the floating ip rules still existed.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/110869

Changed in nova:
assignee: nobody → Alex Xu (xuhj)
status: New → In Progress
Changed in nova:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/110869
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0ed0873240727c2e447613d23ebe1d9e53c79e44
Submitter: Jenkins
Branch: master

commit 0ed0873240727c2e447613d23ebe1d9e53c79e44
Author: He Jie Xu <email address hidden>
Date: Mon Aug 25 17:37:09 2014 +0800

    Update network resource when shelve offload instance

    Commit: 4f8185549dfe11eb1ce405711593baa1528045ea fixes the problem
    by invoke migrate_instance_finish function. But that function should
    be used by only for migration case. This patch use the new network api
    'setup_instance_network_on_host' to update network for instance.

    Also for nova-network, floating-ip should cleanup when unshelve offload
    instance. This patch invoke cleanup_instance_network_on_host when unshelve
    offload instance.

    Change-Id: I75df695ec7b14ebaa25f384ba9a0697a179af03a
    Closes-Bug: #1350704

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.