Request ID header is lost between nova.virt.ironic and ironic-api service

[aeva black]

Services pass request-id headers around to assist with operator interpretation of log files.

This "req-XXX" header is being logged at the nova.virt.ironic layer, but does not seem to be passed to ironic's API service (or is not received / logged there).

[Anusha (anusha-iiitm)]

As per my understanding, this bug is related to the following blueprint http://specs.openstack.org/openstack/nova-specs/specs/juno/approved/log-request-id-mappings.html

As each service generates their own request-id, may be complete solution should be changes in both nova and ironic.
Please correct me if I'm wrong.

[Ramakrishnan G (rameshg87) (rameshg87)]

Yes, I think we need changes in both nova ironic virt driver and ironic. Ironic should be modified to accept request-id headers and log it in API and conductor, and probably after that nova ironic virt driver should pass the request id in headers with Ironic. Might require a change in ironicclient as well.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/210293

[OpenStack Infra (hudson-openstack)]

Change abandoned by Anusha Ramineni (<email address hidden>) on branch: master
Review: https://review.openstack.org/210293

[Sean Dague (sdague)]

It is unclear to me what Nova changes are actually needed here, and the ironic ones to do basic logging are all abandoned. Putting this into incomplete state until it becomes detailed enough to be actionable.

[Jim Rollenhagen (jim-rollenhagen)]

This is covered on the Ironic side by this RFE: https://bugs.launchpad.net/ironic/+bug/1505119

That will return the request ID in the API response, and then return it from the client to the caller.

Once that's all in place, we'll just need to log it in Nova once the request is complete.

[Jim Rollenhagen (jim-rollenhagen)]

Going to close this one on the Ironic side in favor of the RFE https://bugs.launchpad.net/ironic/+bug/1505119

[Markus Zoeller (markus_z) (mzoeller)]

Cleanup
=======

This bug report has the status "Incomplete" since more than 30 days
and it looks like that there are no open reviews for it. To keep
the bug list sane, I close this bug with "won't fix". This does not
mean that it is not a valid bug report, it's more to acknowledge that
no progress can be expected here anymore. You are still free to push a
new patch for this bug. If you could reproduce it on the current master
code or on a maintained stable branch, please switch it to "Confirmed".