nova-network: inconsistent parameters in deallocate_for_instance()

[Oleg Bondarev]

Client side of the network RPC API sets 'requested_networks' parameter in deallocate_for_instance() call [1]
while server side expects 'fixed_ips' parameter [2]

[1] https://github.com/openstack/nova/blob/master/nova/network/rpcapi.py#L183
[2] https://github.com/openstack/nova/blob/master/nova/network/manager.py#L555

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/119745

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/119745
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=03d34c975586788dc25249b5e0b962fc0634008c
Submitter: Jenkins
Branch: master

commit 03d34c975586788dc25249b5e0b962fc0634008c
Author: Oleg Bondarev <email address hidden>
Date: Mon Sep 8 16:45:59 2014 +0400

    Nova-net: fix server side deallocate_for_instance()

    Client side of the network RPC API sets 'requested_networks'
    parameter in deallocate_for_instance() call,
    while server side expected 'fixed_ips' parameter.
    This patch fixes server side so it handles 'requested_networks'

    Closes-Bug: #1350355

    Change-Id: If9554a2e98397c5e63e929e1606d99dd2328262c

[Calvin Walton (kepstin)]

This fix appears to have caused a regression when the "update_dns_entries=True" is set in nova.conf; I've opened a bug at https://bugs.launchpad.net/nova/+bug/1427295 to track that.