nova should not disable retry when there are multiple force hosts/nodes

Bug #1343946 reported by Guangya Liu (Jay Lau)
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
jichenjc

Bug Description

Currently, when there are force_nodes/force_hosts in a scheduler request, retry will be disabled.

This is not right as there might be more than 1 force_nodes/force_hosts, we should not disable retry for such case.

Changed in nova:
assignee: nobody → Jay Lau (jay-lau-513)
importance: Undecided → Medium
Changed in nova:
status: New → In Progress
Revision history for this message
Guangya Liu (Jay Lau) (jay-lau-513) wrote :
Joe Gordon (jogo)
summary: - nova should not disable retry when there are multiple forcde hosts/nodes
+ nova should not disable retry when there are multiple force hosts/nodes
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/108593
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote :

Removing "In Progress" status and assignee as change is abandoned.

Changed in nova:
status: In Progress → Confirmed
assignee: Jay Lau (jay-lau-513) → nobody
Changed in nova:
assignee: nobody → jichenjc (jichenjc)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/108593
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4e7fc7ac56f861b9fe2a535dcafc5b84b249ae24
Submitter: Jenkins
Branch: master

commit 4e7fc7ac56f861b9fe2a535dcafc5b84b249ae24
Author: Jay Lau <email address hidden>
Date: Sun Sep 14 09:18:33 2014 -0400

    Enable retry when there are multiple force hosts/nodes

    Currently, when there are forced hosts/nodes in a scheduler request,
    retry will be disabled. This is not right as there might be multiple
    forced hosts/nodes, we should not disable retry for such case.

    Closes-Bug: #1343946

    DocImpact
    1) If there is only one force host/node, then retry filter will not
    take effect for such case.
    2) If there are multiple force hosts/nodes, retry filter will help
    retry on the force hosts/nodes if there are VM boot failure.

    Change-Id: I6831cab70a70ebbb9609689d9132c731ff84c665

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → kilo-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.