VMware: the retrieval of Datacenter is incorrect

Bug #1343359 reported by Radoslav Gerganov
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Invalid
Low
Unassigned
VMwareAPI-Team
New
Undecided
Unassigned

Bug Description

The implementation of get_datacenter_ref_and_name() in vmops.py is incorrect -- it simply returns the first Datacenter found instead searching for the relevant one.

We need to return the datacenter which contains the corresponding cluster in VMwareVMOps.

Tags: vmware
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote :

@Radoslav, Are you working on this? if not, please unassign

Changed in nova:
assignee: Radoslav Gerganov (rgerganov) → nobody
Thang Pham (thang-pham)
Changed in nova:
assignee: nobody → Thang Pham (thang-pham)
Sean Dague (sdague)
Changed in nova:
status: New → Confirmed
importance: High → Low
Revision history for this message
Thang Pham (thang-pham) wrote :

I took a look at this, and the logic looks correct in the master branch of nova: https://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/vmops.py#L1610. Could you confirm?

Changed in nova:
status: Confirmed → Incomplete
Revision history for this message
Radoslav Gerganov (rgerganov) wrote :

@Thang Correct, this looks fine now, thanks for looking in.

Changed in nova:
status: Incomplete → Invalid
Thang Pham (thang-pham)
Changed in nova:
assignee: Thang Pham (thang-pham) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.