Useless option mute_weight_value

Bug #1340068 reported by Alvaro Lopez
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Davanum Srinivas (DIMS)

Bug Description

The 'mute_weight_value' option for the 'MuteChildWeigher' weigher is useless.

This configuration option was used to artificially inflate the returned weight for a cell that was unavailable, but it is not needed anymore and a multiplier should be used instead. Since the normalization process is already in place, this variable has no effect at all and a muted child will get a weight of 1.0 regardless of the 'mute_weight_value'.

Tags: cells
Alvaro Lopez (aloga)
Changed in nova:
assignee: nobody → Alvaro Lopez (aloga)
status: New → In Progress
Sean Dague (sdague)
Changed in nova:
status: In Progress → Confirmed
importance: Undecided → Low
tags: added: cells
Changed in nova:
assignee: Alvaro Lopez (aloga) → nobody
Revision history for this message
Alvaro Lopez (aloga) wrote :

This has a change submitted here: https://review.openstack.org/#/c/55873/

The sync between gerrit and launchpad did nor work for this ticket for some reason.

Changed in nova:
assignee: nobody → Alvaro Lopez (aloga)
Changed in nova:
status: Confirmed → In Progress
Changed in nova:
assignee: Alvaro Lopez (aloga) → Davanum Srinivas (DIMS) (dims-v)
tags: added: kilo-backport-potential kilo-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/55873
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2399d085f40e201754c8a6af5bdbffbf7a863d5e
Submitter: Jenkins
Branch: master

commit 2399d085f40e201754c8a6af5bdbffbf7a863d5e
Author: Alvaro Lopez Garcia <email address hidden>
Date: Mon Nov 11 17:21:00 2013 +0100

    Scheduler: deprecate mute_weight_value option on weigher

    The nova.cells.weights.mute_child.MuteChildWeigher used a large
    mute_weight_value flag to inflate the weigher's value. This was needed
    before weight normalization was in place, so that the weigher could win
    against other weighers. Now, with weight normalization in place this is
    not needed any more, since the maximum value that a weigher would take will
    be 1.0 (weights are normalized between 0.0 and 1.0). We should use the
    multiplier to get the same behavior (i.e. make the weigher prevail
    against other weighers), the multiplier has been also increased so
    that it actually mutes the other weighers an does not break backwards
    compatibility.

    DocImpact: The mute_weight_value has been marked as deprecated so the
    operators need to adjust the mute_weight_multiplier to a proper value if
    they weren't using the defaults.

    Closes-Bug: #1340068
    Change-Id: Idebd7649909567034b01ce04416ce315fb936b17

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
tags: removed: kilo-backport-potential kilo-rc-potential
Thierry Carrez (ttx)
Changed in nova:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: liberty-1 → 12.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.