compute.instance.create.end no longer has launched_at populated

[Andrew Laski]

The launched_at instance field should be populated with the launch time in the compute.instance.create.end notification. Since the move to build_and_run_instance this field is no longer populated when the notification is sent.

[Tiago Mello (timello)]

Andrew, you mean this change?

diff --git a/nova/compute/manager.py b/nova/compute/manager.py
index 93a752c..6f07834 100644
--- a/nova/compute/manager.py
+++ b/nova/compute/manager.py
@@ -1968,6 +1968,7 @@ class ComputeManager(manager.Manager):
                                       injected_files, admin_password,
                                       network_info=network_info,
                                       block_device_info=block_device_info)
+ instance.launched_at = timeutils.utcnow()
                     self._notify_about_instance_usage(context, instance,
                             'create.end',
                             extra_usage_info={'message': _('Success')},
@@ -2019,7 +2020,6 @@ class ComputeManager(manager.Manager):
         instance.power_state = self._get_power_state(context, instance)
         instance.vm_state = vm_states.ACTIVE
         instance.task_state = None
- instance.launched_at = timeutils.utcnow()
         instance.save(expected_task_state=task_states.SPAWNING)

     @contextlib.contextmanager

[Andrew Laski (alaski)]

Not sure why it didn't update, but https://review.openstack.org/#/c/105276/ is intended to address this.

[Andrew Laski (alaski)]

Tiago, that would address the launched_at time. I reported the scope of the bug too narrowly as really it's the power_state, vm_state, and task_state that should be updated as well.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/105276
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=acb47630f35716f4f3aa1f50d05e3b9280a0a1db
Submitter: Jenkins
Branch: master

commit acb47630f35716f4f3aa1f50d05e3b9280a0a1db
Author: Andrew Laski <email address hidden>
Date: Mon Jul 7 16:44:13 2014 -0400

    Send compute.instance.create.end after launched_at is set

    Downstream consumers of notifications want to know when an instance was
    launched from the compute.instance.create.end notification. This value
    was previously set in the notification but commit
    70196c4854e6cc1cb566dc9fc5b1a3397a4b69ab changed things so that it was
    no longer set. It will now be set, and is tested to be set.

    Change-Id: If5ac00529d52e3898cda7fd942535ed3ba2039d5
    Closes-bug: 1338736