Extract common code from get_fc_wwpns and get_fc_wwnns

Bug #1337304 reported by ling-yun
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Invalid
Wishlist
Unassigned

Bug Description

Since get_fc_wwpns and get_fc_wwnns has almost the same code, so extract common code from these two function and add a flag to identify what info to collect.

ling-yun (zengyunling)
Changed in nova:
assignee: nobody → ling-yun (zengyunling)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/104557

Changed in nova:
status: New → In Progress
Revision history for this message
David McNally (dave-mcnally) wrote :

I'm all for code reuse and clearing up redundancy but I don't think this really constitutes a bug.

Changed in nova:
importance: Undecided → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/104557
Reason: This patch seems effectively abandoned. Please restore if you are still working on it.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote :

Removing "In Progress" status and assignee as change is abandoned.

Changed in nova:
status: In Progress → Confirmed
assignee: ling-yun (zengyunling) → nobody
Revision history for this message
Markus Zoeller (markus_z) (mzoeller) wrote :

That's a refactoring task, neither a bug nor a feature requests, that's why I'm closing this report. If you want to work on that, just push a change for review. Be prepared that refactoring tasks don't get much attention due to the current huge review backlog.

Changed in nova:
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.