VMware: Fail to boot VM when using VDS or the port gropu be created on different vSwitch

[David Geng]

Fail to boot a instance when using the nova-network, I got the error message in log file

'InvalidVLANPortGroup: vSwitch which contains the port group VS5_GUEST_SCODEV_G1_V231 is not associated with the desired physical adapter. Expected vSwitch is vSwitch0, but the one associated is vSwitch5.

Currently, the logic in vmware driver is that all ESXi systems must have the exact same networking configuration (the same PortGroup/vSwitch/pNIC mapping), which typically isn't the case on customer environments.

In my case, on ESX1 the portgroup could be on vSwitch1, but on ESX2 the portgroup could be on vSwitch2, so one of them would fail.
And also if I use the VDS, it doesn't have a physical adapter associated with it and there is a virtual router/firewall connected to that vSwitch which then acts as the gateway for the different PortGroups on it.

So our vSwitch validation should be enhanced.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/104893

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/104893
Reason: This review is > 4 weeks without comment and currently blocked by a core reviewer with a -2. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and contacting the reviewer with the -2 on this review to ensure you address their concerns.

[Davanum Srinivas (DIMS) (dims-v)]

Removing "In Progress" status and assignee as change is abandoned.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/104486
Reason: This patch has been stalled for a long time, so I am abandoning it. Please feel free to restore it when the code is ready for review.

[Markus Zoeller (markus_z) (mzoeller)]

This is an automated cleanup. This bug report has been closed because it
is older than 18 months and there is no open code change to fix this.
After this time it is unlikely that the circumstances which lead to
the observed issue can be reproduced.

If you can reproduce the bug, please:
* reopen the bug report (set to status "New")
* AND add the detailed steps to reproduce the issue (if applicable)
* AND leave a comment "CONFIRMED FOR: <RELEASE_NAME>"
  Only still supported release names are valid (LIBERTY, MITAKA, OCATA, NEWTON).
  Valid example: CONFIRMED FOR: LIBERTY