vlan_start verification error

[Dong Liu]

As we known there are two parameters in creating network, "vlan" and "vlan_start".

In my system, There were 4 networks. And then I created a new network with --vlan argument. The network created success.
But I show this network, the vlan number is 4097. We know this is an invalid vlan.

I think this is a bug and I will fix it.

Follows are my operation record:
root@liudong:~# nova net-list
+--------------------------------------+-----------+-------------+
| ID | Label | CIDR |
+--------------------------------------+-----------+-------------+
| c7e02e11-f469-4aa5-90e7-31af8d89b7d0 | private | 10.0.0.0/24 |
| 684f350a-75ad-40cf-9659-9af40d2b5e35 | network01 | 10.0.1.0/24 |
| b9f4da1d-11fc-4651-85e2-cce4793c5daa | network02 | 10.0.2.0/24 |
| b593fea4-8bd7-4bab-83d9-9e7a22010bc4 | network03 | 10.0.3.0/24 |
+--------------------------------------+-----------+-------------+
root@liudong:~# nova network-create --fixed-range-v4 10.0.4.0/24 --vlan 4093 network04
root@liudong:~# nova network-show network04
+---------------------+--------------------------------------+
| Property | Value |
+---------------------+--------------------------------------+
| bridge | br4097 |
| bridge_interface | eth0 |
| broadcast | 10.0.4.255 |
| cidr | 10.0.4.0/24 |
| cidr_v6 | - |
| created_at | 2014-07-03T04:02:21.000000 |
| deleted | 0 |
| deleted_at | - |
| dhcp_start | 10.0.4.3 |
| dns1 | 8.8.4.4 |
| dns2 | - |
| gateway | 10.0.4.1 |
| gateway_v6 | - |
| host | - |
| id | f9d54d82-e07a-403d-ae29-195625e8c4e8 |
| injected | False |
| label | network04 |
| multi_host | False |
| netmask | 255.255.255.0 |
| netmask_v6 | - |
| priority | - |
| project_id | - |
| rxtx_base | - |
| updated_at | - |
| vlan | 4097 |
| vpn_private_address | 10.0.4.2 |
| vpn_public_address | - |
| vpn_public_port | 1004 |
+---------------------+--------------------------------------+

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/104468

[Sean Dague (sdague)]

I think we need further debug as to why this is going on. The upstream patch doesn't really seem to address the issue correctly. I'm honestly surprised that those command flags produce that result, and seems like an issue somewhere else in the stack.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/104468
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Sean Dague (sdague)]

closing for now, please reopen if you have a reproduce and another patch