Action and action events not soft deleted

[Phil Day]

Entries in the instance_actions and instance_actions_events table should be soft deleted as part of teh associated instance deletion.

[Tracy Jones (tjones-i)]

Phil - can you add more clarity to this. Or if you are going to fix it yourself, can you assign yourself? It's not super clear to me how to tag this bug to make sure it gets attention

[Dan Smith (danms)]

There was some IRC traffic on this one this morning. I think Phil probably knows where to go with this, so lets mark it as assigned to him and he can change that if he wants to add more detail for someone else.

[Takashi Natsume (natsume-takashi)]

Phil,
Are you still working on this bug?
If you are not, may I become the assignee?

[Takashi Natsume (natsume-takashi)]

The records in instance_actions table and instance_actions_events table are not soft deleted when the instance is deleted.

---
stack@devstack-kilo:~/nova$ nova list
+--------------------------------------+---------+--------+------------+-------------+--------------------------------+
| ID | Name | Status | Task State | Power State | Networks |
+--------------------------------------+---------+--------+------------+-------------+--------------------------------+
| b82222e4-87de-4819-b89c-c7c7341995f8 | server1 | ACTIVE | - | Running | public=2001:db8::4, 10.0.2.195 |
+--------------------------------------+---------+--------+------------+-------------+--------------------------------+
stack@devstack-kilo:~/nova$ nova instance-action-list server1
+--------+------------------------------------------+---------+----------------------------+
| Action | Request_ID | Message | Start_Time |
+--------+------------------------------------------+---------+----------------------------+
| create | req-6c71cc9d-5937-4bf6-b4b5-4c1548c44154 | - | 2015-10-06T02:07:33.000000 |
+--------+------------------------------------------+---------+----------------------------+
stack@devstack-kilo:~/nova$ nova instance-action server1 req-6c71cc9d-5937-4bf6-b4b5-4c1548c44154
+---------------+----------------------------------------------------+
| Property | Value |
+---------------+----------------------------------------------------+
| action | create |
| events | [{u'event': u'compute__do_build_and_run_instance', |
| | u'finish_time': u'2015-10-06T02:07:42.000000', |
| | u'result': u'Success', |
| | u'start_time': u'2015-10-06T02:07:34.000000', |
| | u'traceback': None}] |
| instance_uuid | b82222e4-87de-4819-b89c-c7c7341995f8 |
| message | - |
| project_id | c7d594d9a3554138add83d6b36b33e65 |
| request_id | req-6c71cc9d-5937-4bf6-b4b5-4c1548c44154 |
| start_time | 2015-10-06T02:07:33.000000 |
| user_id | a5427de508da4f75814366efdc99e966 |
+---------------+----------------------------------------------------+

mysql> select uuid,deleted,deleted_at from instances where uuid='b82222e4-87de-4819-b89c-c7c7341995f8';
+--------------------------------------+---------+------------+
| uuid | deleted | deleted_at |
+--------------------------------------+---------+------------+
| b82222e4-87de-4819-b89c-c7c7341995f8 | 0 | NULL |
+--------------------------------------+---------+------------+
1 row in set (0.00 sec)

mysql> select id,action,instance_uuid,deleted from instance_actions where instance_uuid='b82222e4-87de-4819-b89c-c7c7341995f8';
+----+--------+--------------------------------------+---------+
| id | action | instance_uuid ...

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/231887

[Matt Riedemann (mriedem)]

See this ML discussion:

http://lists.openstack.org/pipermail/openstack-dev/2015-November/080033.html

And this bp spec:

https://review.openstack.org/#/c/248288/

Basically we're going to hard delete instance_actions and instance_action_events when archiving/purging (hard-deleting) instances, otherwise we're not going to soft delete them.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Takashi NATSUME (<email address hidden>) on branch: master
Review: https://review.openstack.org/231887