the headroom infomation is wrong in the method of limit_check

Bug #1334965 reported by zhangtralon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
zhangtralon

Bug Description

If multiple resources beyond the quotas , the headroom information about the resources beyond the quotas is incomplete(quota.py).
for example:
If the lens of path and content of the injected files exceed the limits, the above situation will appear.
2014-06-27 12:14:04.241 4547 INFO nova.quota [req-a94185e5-779f-4455-ba45-230eb70fb774 None] overs: ['injected_file_content_bytes', 'injected_file_path_bytes']
2014-06-27 12:14:04.241 4547 INFO nova.quota [req-a94185e5-779f-4455-ba45-230eb70fb774 None] headroom: {'injected_file_path_bytes': 255}

Tags: quota
Changed in nova:
assignee: nobody → zhangtralon (zhangchunlong1)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/103297

Changed in nova:
status: New → In Progress
lizheming (lizheming-li)
Changed in nova:
assignee: zhangtralon (zhangchunlong1) → lizheming (lizheming-li)
lizheming (lizheming-li)
Changed in nova:
assignee: lizheming (lizheming-li) → nobody
Changed in nova:
assignee: nobody → zhangtralon (zhangchunlong1)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/103310

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by zhangtralon (<email address hidden>) on branch: master
Review: https://review.openstack.org/103297
Reason: submit another patch

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by zhangtralon (<email address hidden>) on branch: master
Review: https://review.openstack.org/103310
Reason: This patch depends on an abandoned patch,so I will summit another patch to resolve this problem.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by zhangtralon (<email address hidden>) on branch: master
Review: https://review.openstack.org/103297
Reason: This patch depends on an abandoned patch,so I will summit another patch to resolve this problem.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/104435

Revision history for this message
Sean Dague (sdague) wrote :

This is actually a pretty nice cleanup

Changed in nova:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/104435
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d7d4ef350c971c442954d772b639f8b673630896
Submitter: Jenkins
Branch: master

commit d7d4ef350c971c442954d772b639f8b673630896
Author: zhangtralon <email address hidden>
Date: Thu Jul 3 11:45:40 2014 +0800

    the headroom infomation is incomplete

    If multiple resources beyond the quotas in 'limit_check' from
    nova/quota.py. The headroom information about the resources
    beyond the quotas in OverQuota Exception is incomplete.

    Change-Id: I790c22e3618a3558dfad64bf46e37e4e49f6385e
    Closes-Bug: #1334965

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.