EC2 metadata retuns ip of instance and ip of nova-api service node

[NickS]

curl -vL http://169.254.169.254/latest/meta-data/local-ipv4/
* About to connect() to 169.254.169.254 port 80 (#0)
* Trying 169.254.169.254... connected
* Connected to 169.254.169.254 (169.254.169.254) port 80 (#0)
> GET /latest/meta-data/local-ipv4/ HTTP/1.1
> User-Agent: curl/7.19.7 (x86_64-redhat-linux-gnu) libcurl/7.19.7 NSS/3.14.0.0 zlib/1.2.3 libidn/1.18 libssh2/1.4.2
> Host: 169.254.169.254
> Accept: */*
>
< HTTP/1.1 200 OK
< Content-Type: text/html; charset=UTF-8
< Content-Length: 12
< Date: Sun, 22 Jun 2014 15:15:52 GMT
<
* Connection #0 to host 169.254.169.254 left intact
* Closing connection #0
192.168.0.22, 10.2.0.50

192.168.0.22 - instance ip 10.2.0.50 - controller ip

Happens only for /latest/meta-data/local-ipv4/

Quick investigation shows that the issue is caused by

https://github.com/openstack/nova/blob/master/nova/api/metadata/base.py#L243 (https://github.com/openstack/nova/blo...)

'local-ipv4': self.address or fixed_ip, string

self.address variable contains "192.168.0.22, 10.2.0.50" while fixed_ip contains correct "192.168.0.22" value.

The workaround is: swapping those two variables: 'local-ipv4': fixed_ip or self.address, and restart of all nova-compute services

[lizheming (lizheming-li)]

local-ipv4 is instance IP.
http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/AESDG-chapter-instancedata.html

[NickS (n-stakanov)]

Yep correct.
But when you do curl -vL http://169.254.169.254/latest/meta-data/local-ipv4/
it returns <instanceIP, Controller_Local_IP>
curl -vL http://169.254.169.254/latest/meta-data/local-ipv4/ -> 192.168.0.22, 10.2.0.50

instead of curl -vL http://169.254.169.254/latest/meta-data/local-ipv4/ -> 192.168.0.22

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/104138

[Dag Stenstad (dag-stenstad)]

I applied the following patch to my havana nova-api to get this working:

$ diff base.py /usr/share/pyshared/nova/api/metadata/base.py
195,197d194
< fixed_ips = self.ip_info['fixed_ips']
< fixed_ip = fixed_ips and fixed_ips[0] or ''
<
206c203
< 'local-ipv4': fixed_ip or self.address,
---
> 'local-ipv4': self.address,

local-ipv4 is used by CoreOS/discovery.etcd.io to get instances to talk to eachother.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/104138
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=68789d58792ec149bea5e06a7ca1123141daa486
Submitter: Jenkins
Branch: master

commit 68789d58792ec149bea5e06a7ca1123141daa486
Author: lizheming <email address hidden>
Date: Wed Jul 2 17:34:02 2014 +0800

    Get EC2 metadata localip return controller node ip

    When Get EC2 metadata localip, it will return
    <instanceIP, Controller_Local_IP>, but for ec2
    metadata localip, it expects to return instanceIP.
    This patch fixes the issue.

    Change-Id: I6c42e713265ebb3138f7a94df5ee996e6f68d02f
    Closes-Bug: #1334857