nova reports Neutron port OverQuota error when the real problem from Neutron is IpAddressGenerationFailure

[Xu Han Peng]

Nove raise "Neutron error: quota exceeded" when neutron state code is 409 (conflict):

https://github.com/openstack/nova/blob/2014.1.1/nova/network/neutronv2/api.py#L187

The real cause of 409 in Neutron can be OverQuota or IpAddressGenerationFailure(no more IP available from allocation pool). So we need to raise the error from nova side more precisely to reflect the real error.

This can be done to check the exception defined in neutron client:

OverQuotaClient:
https://github.com/openstack/python-neutronclient/blob/master/neutronclient/common/exceptions.py#L142

IpAddressGenerationFailureClient:
https://github.com/openstack/python-neutronclient/blob/master/neutronclient/common/exceptions.py#L152

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/101462

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/101462
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a09e7327aeba03eb6f2b1ae91d49aec9c6475773
Submitter: Jenkins
Branch: master

commit a09e7327aeba03eb6f2b1ae91d49aec9c6475773
Author: Xu Han Peng <email address hidden>
Date: Fri Jun 20 17:37:26 2014 +0800

    Raise specific error of network IP allocation

    Currently Nova raise "Neutron error: quota exceeded" when
    neutron client state code is 409 in IP allocation without
    caring about if the real error is over quota.

    This fixes raises PortLimitExceeded if error from neutron
    client is OverQuota and raises NoMoreFixedIps if error from
    neutron client is IpAddressGenerationFailure. If the error
    is neither of these two errors above, it reraises the original
    exception from neutron client.

    Change-Id: I0d1942587a359acccfca5298c2dcb4b21d971a42
    Closes-Bug: 1331353