"nova show instance_id" gives duplicate security group info (neutron enabled, nova-network disabled)

[Anna Shen]

How to reproduce the bug:

1. devstack with neutron enabled (nova-network disabled)
Num Name Flags

  0 shell $
  1 key $
  2 horizon $
  3 s-proxy $
  4 s-object $
  5 s-container $
  6 s-account $
  7 g-reg $
  8 g-api $
  9 n-api $
 10 q-svc $
 11 q-agt $
 12 q-dhcp $
 13 q-l3 $
 14 q-meta $
 15 n-cpu $
 16 n-cond $
 17 n-crt $
 18 n-sch $
 19 n-cauth $
 20 n-obj $
 21 c-api $
 22 c-sch $
 23 c-vol $
 24 h-eng $
 25 h-api $
 26 h-api-cfn $
 27 h-api-cw $
 28 tr-api $
 29 tr-tmgr $
 30 tr-cond

2. have two private networks
ubuntu@devstack-neutron11:~$ neutron net-list
+--------------------------------------+----------+--------------------------------------------------+
| id | name | subnets |
+--------------------------------------+----------+--------------------------------------------------+
| 0d4f955d-8147-4b2f-9978-c7ea4f4bba43 | public | ab9ee771-99c1-469a-8f6e-62852a9f0c5e |
| 20971b31-6045-457e-ac27-81db78422b61 | private | 5c621409-706b-482f-bde5-76a13ccc22bd 10.0.0.0/24 |
| b6df334b-b833-41a4-816f-0745b7e5462c | customer | e2cd7649-e5ea-4c4b-834c-32b573921fde 10.0.1.0/24 |
+--------------------------------------+----------+--------------------------------------------------+

3. "nova boot" with two nics
ubuntu@devstack-neutron11:~$ nova boot --image... --nic net-id=b6df334b-b833-41a4-816f-0745b7e5462c net-id=20971b31-6045-457e-ac27-81db78422b61 test-nic

4. wait until vm turns ACTIVE
ubuntu@devstack-neutron11:~$ nova list
+--------------------------------------+---------------+--------+------------+-------------+--------------------------------------+
| ID | Name | Status | Task State | Power State | Networks |
+--------------------------------------+---------------+--------+------------+-------------+--------------------------------------+
| c255127b-07e5-49d6-8d0a-913736a6fa0d | test-nic | ACTIVE | - | Running | customer=10.0.1.6; private=10.0.0.53 |
+--------------------------------------+---------------+--------+------------+-------------+--------------------------------------+

5. nova show
ubuntu@devstack-neutron11:~$ nova show c255127b-07e5-49d6-8d0a-913736a6fa0d
+--------------------------------------+----------------------------------------------------------------------------------------------+
| Property | Value |
+--------------------------------------+----------------------------------------------------------------------------------------------+
| OS-DCF:diskConfig | MANUAL |
| OS-EXT-AZ:availability_zone | nova |
| OS-EXT-STS:power_state | 1 |
| OS-EXT-STS:task_state | - |
| OS-EXT-STS:vm_state | active |
| OS-SRV-USG:launched_at | 2014-06-17T23:57:58.000000 |
| OS-SRV-USG:terminated_at | - |
| accessIPv4 | |
| accessIPv6 | |
| config_drive | |
| created | 2014-06-17T23:57:40Z |
| customer network | 10.0.1.6 |
| flavor | m1.small (2) |
| hostId | f4d3488a1d1eb9d74876ac506062a9c2daf2d62b468c205b8a9e1e3e |
| id | c255127b-07e5-49d6-8d0a-913736a6fa0d |
| image | ubuntu_mysql (7c3333fa-08bc-45c3-afef-4497c48602cc) |
| key_name | - |
| metadata | {} |
| name | test-nic |
| os-extended-volumes:volumes_attached | [{"id": "aed807d0-e1cc-4e7e-9653-0655bcbfd0a6"}] |
| private network | 10.0.0.53 |
| progress | 0 |
| security_groups | SecGroup_af383114-4a31-4adf-bbd4-0463b8ed20b8, SecGroup_af383114-4a31-4adf-bbd4-0463b8ed20b8 |
| status | ACTIVE |
| tenant_id | aca81527ffe04e0da75a0bad84060bae |
| updated | 2014-06-17T23:57:58Z |
| user_id | 026664788f664d84bc210fb3c6eb2649 |
+--------------------------------------+----------------------------------------------------------------------------------------------+

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/120950

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/120950
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=3d68063809547e37f862dba448dcf669b7a4445c
Submitter: Jenkins
Branch: master

commit 3d68063809547e37f862dba448dcf669b7a4445c
Author: Sean Dague <email address hidden>
Date: Thu Sep 11 20:44:44 2014 -0400

    Don't display duplicated security groups

    As reported by users, we end up displaying duplicate security groups
    on multi nic vms using neutron. Let's not do that.

    Also add security group listing to the v3 client to make it
    consistent.

    Change-Id: I0a983aac08aaeacf3c2aef5aae49f64265fe78c5
    Closes-Bug: #1331307