leave instances in original state when nova compute restart with error

[wei du]

Currently, during nova-compute restart, when CONF.resume_guests_state_on_host_boot is set true and there is a problem during a nova-compute restart (for example, a network card has issues), all existing will be put into ERROR state.

In the patch, we just leave the instance in original state. This way, we can directly run ‘nova reboot’ to get the instance back after errors got fixed. With an instance in ‘ERROR’ state, one has to manually change the DB record to other state before running ‘nova reboot’.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/102612

[Sean Dague (sdague)]

seems stalled upstream will lots of negative feedback on current patch. Alternative approaches welcomed.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Joe Gordon (<email address hidden>) on branch: master
Review: https://review.openstack.org/99202
Reason: see above

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/102612
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Jinquan Ni (ni-jinquan)]

Fix proposed to branch: master
Review: https://review.openstack.org/#/c/289380/1

[OpenStack Infra (hudson-openstack)]

Change abandoned by jinquanni (<email address hidden>) on branch: master
Review: https://review.openstack.org/289380
Reason: code mix， i will commit a new

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/289745

[Alex Szarka (xavvior)]

Please provide all the related logs, steps and more accurate information about this bug. How can I reproduce this bug, what are the steps needed to reproduce this bug? Also, the bug report is not really clear, also, the description has some false information. Please give us some scenarios, so we can reproduce the bug, and more detailed description of the issue.

[Jinquan Ni (ni-jinquan)]

If you want reproduce this bug, you can do like this:

1) create a vm
2) go to the compute node which the vm on, unplug the physical net card(we can regard the card has some proplems)
3) reboot the compute node
4) the vm wll enter error state because bad network
5) re-plug the physical net card(we can regard the card's proplem be fixed)
6) reboot the compute node again, we hope the vm can back to active, but now, it can't

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/289745
Reason: This patch has been sitting unchanged for more than 12 weeks. I am therefore going to abandon it to keep the nova review queue sane. Please feel free to restore the change if you're still working on it.

[Sean Dague (sdague)]

Patch abandoned

[Nazeema Begum (nazeema123)]

Please provide all the related logs, steps and more accurate information about this bug. How can I reproduce this bug, what are the steps needed to reproduce this bug? Also, the bug report is not really clear, also, the description has some false information. Please give us some scenarios, so we can reproduce the bug, and more detailed description of the issue.

[Jay Pipes (jaypipes)]

As someone on one of the reviews commented, you can do a `nova reboot --hard` to reboot a VM that is in ERROR state after a failed nova-compute restart.

Closing this as Invalid.