Activity log for bug #1330503

Date Who What changed Old value New value Message
2014-06-16 14:16:36 David McNally bug added bug
2014-06-16 14:43:43 Mark McLoughlin description During compute manager startup init_host is called. One of the functions there is to delete instance data that doesn't belong to this host i.e. _destroy_evacuated_instances. But this function only checks if the local instance belongs to the host or not. It doesn't check the task_state. If at this time a a resize migration is taking place and the destination compute manager is restarted it might destroy the resizing instance. A similar bug concerning just the migrating state is outlined here: https://bugs.launchpad.net/nova/+bug/1319797 and a fix is proposed here: https://review.openstack.org/#/c/93903 It was intended to have that fix deal with resize migrating instances as well as those just in the migrating state but as pointed out in a review comment this solution will work for migrating but a fix for resize would require further changes so I have raised this bug to highlight that. During compute manager startup init_host is called. One of the functions there is to delete instance data that doesn't belong to this host i.e. _destroy_evacuated_instances. But this function only checks if the local instance belongs to the host or not. It doesn't check the task_state or vm_state. If at this time a resize migration is taking place and the destination compute manager is restarted it might destroy the resizing instance. Alternatively, if the resize has completed (vm_state = RESIZED) but has not been confirmed/reverted, then a restart of the source compute manager might destroy the original instance. A similar bug concerning just the migrating state is outlined here: https://bugs.launchpad.net/nova/+bug/1319797 and a fix is proposed here: https://review.openstack.org/#/c/93903 It was intended to have that fix deal with resize migrating instances as well as those just in the migrating state but as pointed out in a review comment this solution will work for migrating but a fix for resize would require further changes so I have raised this bug to highlight that.
2014-06-16 14:43:47 Mark McLoughlin nova: importance Undecided High
2014-06-16 14:43:51 Mark McLoughlin nova: status New Triaged
2014-06-16 14:44:02 Mark McLoughlin tags compute icehouse-backport-potential
2014-06-20 08:00:48 jichenjc nova: assignee jichenjc (jichenjc)
2014-06-23 05:37:22 OpenStack Infra nova: status Triaged In Progress
2014-07-09 07:41:30 Yoshiaki Kosaka bug added subscriber Yoshiaki Kosaka
2014-07-28 04:17:53 OpenStack Infra nova: status In Progress Fix Committed
2014-09-05 09:47:53 Thierry Carrez nova: status Fix Committed Fix Released
2014-09-05 09:47:53 Thierry Carrez nova: milestone juno-3
2014-10-16 08:45:52 Thierry Carrez nova: milestone juno-3 2014.2