vmware: VCdriver creates same hypervisor_hostname for different vcenters with same Cluster name

[Kanagaraj Manickam]

Consider the following scenario, where two nova-compute nodes are configured to different vcenter with same cluster named "Cluster1":

Compute-Node #1:
-----------------------
hostname: devstack1
vmware.host_ip: 10.1.0.12
vmware.cluster_names: Cluster1 << Same cluster name

Compute-Node #2:
-------------------------
hostname: devstack2
vmware.host_ip: 10.1.0.13
vmware.cluster_names: Cluster1 << Same cluster name

hypervisor_hostname=domain-c26(Cluster1)

 In this scenario, VC driver creates the same value for compute_nodes.hypervisor_hostname as mentioned here.

------------------------------------------------
Compute_node | hypervisor_hostname
------------------------------------------------
#1 | domain-c26(Cluster1)
#2 | domain-c26(Cluster1)
------------------------------------------------

 Because same compute_nodes.hypervisor_hostname is created for more than one clusters, it creates the following issues in the horizon:

1. In admin->Hypervisors, the same CPU, Memory utilization is reported for both the clusters
2. In admin -> Hypervisors-> [Click on Hypervisor #1]->, the details page reports the same list of instance for both the clusters.

Though the issue is seen in the horizon, the actual root cause is because vcdriver creates the same hypervisor_hostname for both the clusters.

so this bug is filed to fix this issue, to create the hypervisor_hostname as follows:
<vmware.host_ip (vmware.cluster_name)>

Ex: 10.1.0.12 (Cluster1)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/99623

[Tracy Jones (tjones-i)]

sorry - bugs that affect only a particular hypervisor cannot be critical. I'll add this to the vmwareapi-team and mark critical.

[Michael Still (mikal)]

Is anyone working this bug?

[Kanagaraj Manickam (kanagaraj-manickam)]

Hi MIchael,

This bug fix is under review Review: https://review.openstack.org/99623

There is one +2, waiting for another one.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/99623
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Davanum Srinivas (DIMS) (dims-v)]

Removing "In Progress" status and assignee as change is abandoned.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/159481

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/159481
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ce690113c620a3c3a25f8f6d2bfdbaf4e7d2b0d1
Submitter: Jenkins
Branch: master

commit ce690113c620a3c3a25f8f6d2bfdbaf4e7d2b0d1
Author: Kanagaraj Manickam <email address hidden>
Date: Thu Jun 12 16:14:23 2014 +0530

    VMware: Ensure compute_node.hypervisor_hostname is unique

    The VMware driver currently identifies a hypervisor as:

      <mo_id>(<cluster name>)

    Cluster name is not unique, and mo_id is only unique in the scope of a
    single vCenter, so the above can produce duplicate names when managing
    clusters with the same name in multiple vCenters. This is especially
    likely to occur in lab setups.

    This change alters the above format to the following, which uniquely
    identifies a cluster globally:

      <mo_id>.<vCenter uuid>

    Closes-bug: #1329261
    Co-Authored-By: Kanagaraj Manickam <email address hidden>
    Change-Id: I2f3b5d224cc653d0465598de0788116e71d1ca0d