nova can not stop a vm when using fake driver

[Feng Xi Yan]

When using fake driver, "nova stop" command did not change the instance's power state.

Steps to reproduce the bug:
(1) Config nova to use fake drive
vim /etc/nova/nova.conf
compute_driver = fake.FakeDriver

(2) Boot a VM
+----------------------------------------------+-------+------------+--------------+--------------+------------------------+
| ID | Name | Status | Task State | Power State | Networks |
+----------------------------------------------+-------+------------+--------------+--------------+------------------------+
| 23f4abf8-664b-4aff-bf9e-fdad35cc7a9d | test | ACTIVE | - | Running | test-net=55.0.0.125 |
+----------------------------------------------+-------+------------+--------------+--------------+------------------------+

(3) Stop this instance with "nova stop" command
$> nova stop test
$> nova list
+----------------------------------------------+-------+------------+--------------+--------------+------------------------+
| ID | Name | Status | Task State | Power State | Networks |
+----------------------------------------------+-------+------------+--------------+--------------+------------------------+
| 23f4abf8-664b-4aff-bf9e-fdad35cc7a9d | test | SHUTOFF | - | Running | test-net=55.0.0.125 |
+----------------------------------------------+-------+------------+--------------+--------------+------------------------+

(4) We can see the power state is still "Running", while it should be “Showdown".

[Feng Xi Yan (yanfengxi)]

Fix proposed to branch: master
Review: https://review.openstack.org/99825/

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/99825
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Noel Nelson Dsouza (noelnelson)]

Please provide the version of OpenStack used for above..

I am currently checking on Juno version of Openstack-devstack

Regards
Noel Nelson Dsouza

[Noel Nelson Dsouza (noelnelson)]

I have reproduced above bug in Juno version Openstack Devstack,

Steps I followed :

1) Launch the instance with proper compute_driver
2) Delete the instance . Command : nova delete InstanceName.
3) Change the content of file /etc/nova/nova.conf as : compute_driver = fake.FakeDriver
4) Restart only all nova services manually. ( Using screen option in devstack)
5) Launch the instance with fake compute driver ( Step 1 repeat).
6) Stop the instance. ( nova stop InstanceName)

Regards
Noel Nelson Dsouza

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/174746

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/182650

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/174746
Reason: This patch has been stalled for a long time, so I am abandoning it. Please feel free to restore it when the code is ready for review.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/182650
Reason: This patch has been stalled for quite a while, so I am going to abandon it to keep the code review queue sane. Please restore the change when it is ready for review.

[Noel Nelson Dsouza (noelnelson)]

Using Fake driver not able to launch instances. If we launch also it should be in error state.