libvirt does not store connection_info after BFV setup

[Dan Smith]

If booting from a volume, the virt driver does the setup of the volume with cinder before starting the instance. This differs from the attach volume case, which is managed by nova itself. Since the connect operation could yield new details in the connection_info structure that need to be persisted until teardown time, it is important that the connection_info be written back after connect completes. Nova's attach_volume() does this, but libvirt does not. Specifically in the case of the fibre channel code, this means we don't persist information about multipath devices which means we don't fully tear down everything at disconnect time.

This is present in at least Havana, and I expect it is present in Icehosue and master as well.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/havana
Review: https://review.openstack.org/98874

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/99699

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/99699
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a1a2d0605b555f149846eb7e74f7d1760e55ed75
Submitter: Jenkins
Branch: master

commit a1a2d0605b555f149846eb7e74f7d1760e55ed75
Author: Dan Smith <email address hidden>
Date: Thu Jun 12 08:56:21 2014 -0700

    Save connection info in libvirt after volume connect

    The libvirt driver will connect volumes for BFV while processing
    the guest configuration, but not save the connection_info into
    the database. This adds a save there to make sure that any
    storage driver details get persisted.

    Change-Id: Ia99e04ad80a2823a6852debf0919e72b2f93bd26
    Related-bug: #1328245

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/100556

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/98874
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a2aca5c9fb2afaa2f66cefc6cf19c658e6f44430
Submitter: Jenkins
Branch: stable/havana

commit a2aca5c9fb2afaa2f66cefc6cf19c658e6f44430
Author: Dan Smith <email address hidden>
Date: Fri May 23 07:05:52 2014 -0700

    Save connection info in libvirt after volume connect

    The libvirt driver will connect volumes for BFV while processing
    the guest configuration, but not save the connection_info into
    the database. This adds a save there to make sure that any
    storage driver details get persisted.

    Related-bug: #1328245

    Change-Id: Idd6ef94ba2129b65e685a0435bc79f213d6f3f04

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/100556
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a365897a32714e37c0b190594c0bdc827adb36f9
Submitter: Jenkins
Branch: stable/icehouse

commit a365897a32714e37c0b190594c0bdc827adb36f9
Author: Dan Smith <email address hidden>
Date: Thu Jun 12 08:56:21 2014 -0700

    Save connection info in libvirt after volume connect

    The libvirt driver will connect volumes for BFV while processing
    the guest configuration, but not save the connection_info into
    the database. This adds a save there to make sure that any
    storage driver details get persisted.

    Change-Id: Ia99e04ad80a2823a6852debf0919e72b2f93bd26
    Related-bug: #1328245
    (cherry picked from commit a1a2d0605b555f149846eb7e74f7d1760e55ed75)