Huge test case for Ironic Nova driver should be split

Bug #1325906 reported by Dmitry Tantsur
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Won't Fix
Wishlist
Unassigned
OpenStack Compute (nova)
Won't Fix
Wishlist
Aniruddha Singh Gautam

Bug Description

Currently, tests for Ironic Nova driver consist of one giant test case. That is not convenient from mocking point of view, as it requires different set of mocks to be places on every method. It is also hard to reason about. Splitting into several meaningful test cases will allow to have mock decorators mostly at class-levels, which will lead to less cluttered code. It will also simplify review for Nova folks.

Dmitry Tantsur (divius)
Changed in ironic:
status: New → Triaged
importance: Undecided → Wishlist
tags: added: low-hanging-fruit
Zhongyue Luo (zyluo)
Changed in ironic:
assignee: nobody → Zhongyue Luo (zyluo)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/106933

Changed in ironic:
status: Triaged → In Progress
Revision history for this message
Dmitry Tantsur (divius) wrote : Re: Huge test case for Nova driver should be split

Should be fixed in Nova now - driver is no longer in Ironic tree

summary: - Huge test case for Nova driver should be split
+ Huge test case for Ironic Nova driver should be split
Changed in ironic:
status: In Progress → Won't Fix
tags: added: ironic
Sean Dague (sdague)
Changed in nova:
importance: Undecided → Wishlist
status: New → Triaged
Changed in ironic:
assignee: Zhongyue Luo (zyluo) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ironic (master)

Change abandoned by Lucas Alvares Gomes (<email address hidden>) on branch: master
Review: https://review.openstack.org/106933
Reason: Thanks for the patch! Unfortunately the changes doesn't belongs to Ironic anymore, the Ironic Nova driver was finally moved to the Nova tree (yay). Please resubmit it to Nova.

Thanks again!

Changed in nova:
assignee: nobody → Ankur Gupta (ankur-gupta-v)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/135185

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/135230

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Ankur Gupta (<email address hidden>) on branch: master
Review: https://review.openstack.org/135185
Reason: Creating new review-
https://review.openstack.org/#/c/135230/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/135554

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Jeremy Stanley (<email address hidden>) on branch: master
Review: https://review.openstack.org/135554
Reason: This change appears to have been uploaded in error. https://ask.openstack.org/en/question/53715

Changed in nova:
assignee: Ankur Gupta (ankur-gupta-v) → Jeremy Stanley (fungi)
Revision history for this message
Jeremy Stanley (fungi) wrote :

The current proposed nova patch for this is https://review.openstack.org/135230

Changed in nova:
assignee: Jeremy Stanley (fungi) → Ankur Gupta (ankur-gupta-v)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/135230
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote :

Fix proposed is currently in progress - https://review.openstack.org/135230

Changed in nova:
assignee: Ankur Gupta (ankur-gupta-v) → nobody
status: In Progress → Confirmed
Changed in nova:
assignee: nobody → Aniruddha Singh Gautam (aniruddha-gautam)
Sean Dague (sdague)
Changed in nova:
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers