Invalid error message for snapshot creation in EC2 layer

[Feodor Tersin]

Volume snapshots in EC2 can be created only for volumes in some particular statuses. For other statuses creation an error should be returned. Current EC2 code doesn't check the statuses and pass the request to Cinder code. When it fails creating it returns its own native error which is incorrectly reported further by EC2 layer.

Environment: DevStack

Steps to reproduce:
1 Run from script:
vol=$(euca-create-volume -z nova -s 1 --snapshot snap-xxx | awk -F " " '{print $2}')
euca-create-snapshot $vol

InvalidInput: Invalid input received: Invalid volume: must be available

If run tthis agains AWS the error output is
IncorrectState: Volume 'vol-xxx' is not in a state where snapshots are allowed.

Note. To reproduce the error on AWS i recommend to get a non-empty snapshot about 10GB and increase the size parameter in euca-create-volume.

[Sean Dague (sdague)]

Does not appear to be in progress

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/96280
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Andrey Pavlov (apavlov-e)]

it works in stackforge/ec2-api project.