Server_group shouldn't have same policies in it

Bug #1324348 reported by wingwj
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
wingwj
tempest
Fix Released
Undecided
wingwj

Bug Description

It can put several same policies in one server_group now.
It doesn't make sense, the duplicate policies need to be ignored.

------------

stack@devaio:~$ nova server-group-create --policy affinity --policy affinity wjsg1
+--------------------------------------+-------+----------------------------+---------+----------+
| Id | Name | Policies | Members | Metadata |
+--------------------------------------+-------+----------------------------+---------+----------+
| 4f6679b7-f6b1-4d1e-92cd-1a54e1fe0f3d | wjsg1 | [u'affinity', u'affinity'] | [] | {} |
+--------------------------------------+-------+----------------------------+---------+----------+
stack@devaio:~$

wingwj (wingwj)
Changed in nova:
assignee: nobody → wingwj (wingwj)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/96397

Changed in nova:
status: New → In Progress
wingwj (wingwj)
Changed in tempest:
assignee: nobody → wingwj (wingwj)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tempest (master)

Fix proposed to branch: master
Review: https://review.openstack.org/96645

Changed in tempest:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tempest (master)

Reviewed: https://review.openstack.org/96645
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=af630da010ae7083e0a4da87b5014f45d90ac7ef
Submitter: Jenkins
Branch: master

commit af630da010ae7083e0a4da87b5014f45d90ac7ef
Author: wingwj <email address hidden>
Date: Fri May 30 09:21:30 2014 +0800

    Don't store duplicate policies for server_group

    It doesn't make sense to store same policies in a server_group.
    We only need to store one and ignore the duplicate policies.

    This patch relates to the bug I4f3ad544aef78cbbc076c7a47cca04832a2f5b4b
    in Nova. So I need to skip one test-case here firstly in order to modify the
    issue in Nova.

    After the Nova's patch merged, this test-case will be restored,
    and more correlate cases will definitly be supplied in tempest.

    Change-Id: I26449a2a881be396daf75838451cfe01a915f513
    Closes-Bug: #1324348

Changed in tempest:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/96397
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=57eef4dd26b1caa487e78fadb0f02f1d5154a508
Submitter: Jenkins
Branch: master

commit 57eef4dd26b1caa487e78fadb0f02f1d5154a508
Author: wingwj <email address hidden>
Date: Thu May 29 16:26:14 2014 +0800

    Don't store duplicate policies for server_group

    It doesn't make sense to store same policies in a server_group.
    We need to deny this usage in server_group creation.

    Change-Id: I4f3ad544aef78cbbc076c7a47cca04832a2f5b4b
    Closes-Bug: #1324348

Changed in nova:
status: In Progress → Fix Committed
wingwj (wingwj)
tags: added: icehouse-backport-potential
tags: added: api
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/103285

Changed in nova:
milestone: none → juno-2
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tempest (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/121574

Thierry Carrez (ttx)
Changed in nova:
milestone: juno-2 → 2014.2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tempest (master)

Change abandoned by Matthew Treinish (<email address hidden>) on branch: master
Review: https://review.openstack.org/121574

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tempest (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/152224

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (stable/icehouse)

Change abandoned by Matt Riedemann (<email address hidden>) on branch: stable/icehouse
Review: https://review.openstack.org/103285
Reason: No response for nearly a year on this so abandoning.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tempest (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/247001

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tempest (master)

Change abandoned by Andrey Kurilin (<email address hidden>) on branch: master
Review: https://review.openstack.org/247001

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Matthew Treinish (<email address hidden>) on branch: master
Review: https://review.openstack.org/152224

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.