Hyper-V driver volumes are attached incorrectly when multiple iSCSI servers are present

[Alessandro Pilotti]

Hyper-V can change the order of the mounted drives when rebooting a host and thus passthrough disks can be assigned to the wrong instance resulting in a critical scenario.

[Tracy Jones (tjones-i)]

this is not critical from a nova point of view (though it may be for hyper-v). The priorities should be overall project prio, not individual driver prio

[John Garbutt (johngarbutt)]

We use milestones only at the very end of the milestone to track bugs that should block the release of the milestone. Please use tags not milestones to track bugs, try things like: my_bug_topic_milestone_name

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/120377

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/95356
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=50636a881b60f112027494bcd84af66888db8c1c
Submitter: Jenkins
Branch: master

commit 50636a881b60f112027494bcd84af66888db8c1c
Author: Alessandro Pilotti <email address hidden>
Date: Sun May 25 04:50:35 2014 +0300

    Fixes Hyper-V volume mapping issue on reboot

    Hyper-V does not manage iSCSI mounted passthrough disks
    correctly on reboot in some circumstances where disk
    number assignment can change, resulting in instances potentially
    booting with the wrong volume attached.

    Co-Authored-By: Adelina Tuvenie <email address hidden>
    Co-Authored-By: Adrian Bora <email address hidden>

    Change-Id: I99fa75aaa950de2ada8a03bd23c910c3ff810d69
    Closes-Bug: #1322926

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/120377
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4174130d66c892ac0e9ec7db822dc3b07b8bca89
Submitter: Jenkins
Branch: stable/icehouse

commit 4174130d66c892ac0e9ec7db822dc3b07b8bca89
Author: Alessandro Pilotti <email address hidden>
Date: Sun May 25 04:50:35 2014 +0300

    Fixes Hyper-V volume mapping issue on reboot

    Hyper-V does not manage iSCSI mounted passthrough disks
    correctly on reboot in some circumstances where disk
    number assignment can change, resulting in instances potentially
    booting with the wrong volume attached.

    Co-Authored-By: Adelina Tuvenie <email address hidden>
    Co-Authored-By: Adrian Bora <email address hidden>

    Closes-Bug: #1322926
    (cherry picked from commit 50636a881b60f112027494bcd84af66888db8c1c)

    Conflicts:
     nova/tests/virt/hyperv/test_vmutils.py
     nova/tests/virt/hyperv/test_vmutilsv2.py
     nova/virt/hyperv/vmutils.py
     nova/virt/hyperv/vmutilsv2.py

    Change-Id: I99fa75aaa950de2ada8a03bd23c910c3ff810d69