Instance Lock should protect Snapshot

[Justin Hopper]

The use of instance lock should be to prevent unwanted modification of the underlying VM. In the case of Trove, we are using it to help lock down instances to ensure integrity and protect secrets which are needed by the resident Trove Agent. Even though we lock a machine, the end-user can still take a snapshot of the instance to create an image, then restore the image in an unrestricted manner. Once they have access to this restored image, it can up the Trove Control Plane for compromise. Simply adding a check_instance_lock around live_instance_snapshot and snapshot would be sufficient.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/99910

[OpenStack Infra (hudson-openstack)]

Change abandoned by melanie witt (<email address hidden>) on branch: master
Review: https://review.openstack.org/99910
Reason: Based on ML thread [1] snapshot should be allowed for locked instances. Instance lock is a feature for preventing accidental change/deletion of instances and isn't intended to lock out voluntary actions or protect the content of an instance.

[1] http://lists.openstack.org/pipermail/openstack-dev/2014-June/037853.html

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/101972

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/101972
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1c88b2d9cb097c27cab71dc52ae92bf66f3e8d0d
Submitter: Jenkins
Branch: master

commit 1c88b2d9cb097c27cab71dc52ae92bf66f3e8d0d
Author: melanie witt <email address hidden>
Date: Mon Jun 23 18:18:13 2014 +0000

    add comment about why snapshot/backup have no lock check

    This comment is intended to reduce further confusion about why a
    lock check hasn't been implemented for snapshot and backup.

    Change-Id: I8d89ca7b15d6713221af2d0535f9ed338ca70612
    Related-Bug: #1314741