tenant is required for quota-update but not for quota-show

[Corey Bryant]

Tenant is a required positional parameter on quota-update but is optional on quota-show. And when --tenant is not specified on quota-show it doesn't return valid limits for the user.

$ nova quota-show --user demo
+-----------------------------+-------+
| Quota | Limit |
+-----------------------------+-------+
| instances | 10 |
...
+-----------------------------+-------+

$ nova quota-update --user demo --instances 9 # tenant is required
usage: nova quota-update [--user <user-id>] [--instances <instances>]
                         [--cores <cores>] [--ram <ram>]
                         [--floating-ips <floating-ips>]
                         [--fixed-ips <fixed-ips>]
                         [--metadata-items <metadata-items>]
                         [--injected-files <injected-files>]
                         [--injected-file-content-bytes <injected-file-content-bytes>]
                         [--injected-file-path-bytes <injected-file-path-bytes>]
                         [--key-pairs <key-pairs>]
                         [--security-groups <security-groups>]
                         [--security-group-rules <security-group-rules>]
                         [--force]
                         <tenant-id>
error: too few arguments
Try 'nova help quota-update' for more information.

$ nova quota-update --user demo --instances 9 demo

$ nova quota-show --user demo # should return instances=9 or should fail because tenant is required
+-----------------------------+-------+
| Quota | Limit |
+-----------------------------+-------+
| instances | 10 |
...
+-----------------------------+-------+

$ nova quota-show --user demo --tenant demo # returns the correct value
+-----------------------------+-------+
| Quota | Limit |
+-----------------------------+-------+
| instances | 9 |
...
+-----------------------------+-------+

[Thang Pham (thang-pham)]

The problem is nova quota-update uses value of <tenant-id> to save the quota in the database. If you use "demo" as the tenant-id, nova will use project_id="demo" when setting the project_user_quotas table. If you use a <uuid> as the tenant-id, nova will use project_id=<uuid> when setting the project_user_quotas table. You can see this by logging into MySQL (or whatever DB you are using) and querying the project_user_quotas table (e.g. select project_id,resource,hard_limit from project_user_quotas).

In order to obtain the correct values, you have to pass the correct <tenant-id> in nova quota-show. The solution to this bug is to: translate the tenant name into its <uuid> before saving it into the DB or querying from the database.

[Thang Pham (thang-pham)]

Another solution is: check that the <tenant-id> is actually a valid uuid.

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/91866

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Joe Gordon (<email address hidden>) on branch: master
Review: https://review.openstack.org/91866
Reason: Is this still active? Nothing has happened in a few months marking as abandoned. Feel free to bring it back.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Thang Pham (<email address hidden>) on branch: master
Review: https://review.openstack.org/91866
Reason: Abandoning this patch, so a new patch can be spun up with updated code.

[Anton Arefiev (aarefiev)]

Cinder quota-show and quota-update have only positional arg <tenant_id>.