attach_volume doesn't work in cells when api is icehouse and compute is havana

[Sam Morrison]

This affects Havana not Icehouse

The method signature of attach_volume changed from Havana -> Icehouse

- def attach_volume(self, context, instance, volume_id, device=None):
+ def attach_volume(self, context, instance, volume_id, device=None,
+ disk_bus=None, device_type=None):

[Joe Gordon (jogo)]

Although I cannot validate this myself, I am not surprised to see this, in our rolling upgrade testing we didn't use cells. At this point I don't think we can really retroactively fix this, I think the best we can do is try to get better cells testing in the gate.

Sam, just to be clear this breaks if you use cells?

[Joe Gordon (jogo)]

Marking this as a won't fix since I am not sure how we can easily fix this without requiring patches to havana

[Chris Behrens (cbehrens)]

Agree with "won't fix". There's a number of things related to objects that need fixed with cells yet, also, to allow rolling upgrades.

[Sam Morrison (sorrison)]

Yeah all good, we have a simple patch in our havana tree to add those two arguments and just do nothing with them to match the method signature. Seems to work fine.