nova.objects.base imports conductor wrong

Bug #1308811 reported by Sam Morrison
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Sam Morrison

Bug Description

in nova.objects.base it imports conductor

from nova.conductor import api as conductor_api
self._conductor = conductor_api.API()

This bypasses the logic to detemin whether to use conductor RPC service or not.

Should do

from nova import conductor
self._conductor = conductor.API()

Revision history for this message
Sam Morrison (sorrison) wrote :
Changed in nova:
assignee: nobody → Sam Morrison (sorrison)
status: New → In Progress
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/88123
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5427630f735381569066815605c75bccd278def8
Submitter: Jenkins
Branch: master

commit 5427630f735381569066815605c75bccd278def8
Author: Sam Morrison <email address hidden>
Date: Thu Apr 17 12:03:10 2014 +1000

    Fix up import of conductor

    Need to import API from nova.conductor not from nova.conductor.api
    directly. This is needed so the is_local flag can be used to
    determine the conductor API to use (local or rpc)

    Change-Id: I9a45a705a39050b296936edc486db5c2f0aae4dc
    Closes-Bug: #1308811

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.