Unshelve instance needs handling exceptions

Bug #1307416 reported by Sahid Orentino
24
This bug affects 6 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Sahid Orentino

Bug Description

There are some error cases not handled when we unshelve an instance in the conductor.

   nova/conductor/manager.py#823

if the key 'shelved_image_id' is not defined the current code will raise an KeyError not handled.
Also when the 'shelved_image_id' is set to None (which is not the expected behavior), the error is not correctly handled and the message could be confusing.

Tags: conductor
description: updated
tags: added: conductor
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/71907
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c58f2393b1c88268179205e349a2638f481bd492
Submitter: Jenkins
Branch: master

commit c58f2393b1c88268179205e349a2638f481bd492
Author: Sahid Orentino Ferdjaoui <email address hidden>
Date: Thu Apr 24 18:57:44 2014 +0200

    Improve conductor error cases when unshelving

    This commit handles different cases when the key 'shelved_image_id'
    is not defined or None. Also it tries to improve the error messages.

    Closes-Bug: #1307416
    Change-Id: Ia2d0a183eefccdfd6f612d86f60cd2930c1a4b23

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.