VMware: waste of disk datastore when root disk size of instance is 0

[Gary Kotton]

When an instance has 0 root disk size an extra image is created on the datastore (uuid.0.vmdk that is identical to uuid.vmdk). This is only in the case of a linked clone image and wastes space on the datastore. The original image that is cached can be used.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/86115

[John Garbutt (johngarbutt)]

We use milestones only at the very end of the milestone to track bugs that should block the release of the milestone. Please use tags not milestones to track bugs, try things like: my_bug_topic_milestone_name

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/86115
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=9b14ae62a6396a2599c8a2ada1a50e3f69a2eddc
Submitter: Jenkins
Branch: master

commit 9b14ae62a6396a2599c8a2ada1a50e3f69a2eddc
Author: Gary Kotton <email address hidden>
Date: Tue Apr 8 11:28:27 2014 -0700

    VMware: do not cache image when root_gb is 0

    Save space on datastore when the instance size has root_gb of
    0. There is no need to cache the disk as it already exists on
    the datastore.

    TrivialFix

    Change-Id: Iac75d97f40a1a91b8fa2df7fb4318fc2965fd93a
    Closes-bug: #1304593

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/111752

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/111752
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=471e644199e0eecfd621baacbe7b0dba6d029387
Submitter: Jenkins
Branch: stable/icehouse

commit 471e644199e0eecfd621baacbe7b0dba6d029387
Author: Gary Kotton <email address hidden>
Date: Tue Apr 8 11:28:27 2014 -0700

    VMware: do not cache image when root_gb is 0

    Save space on datastore when the instance size has root_gb of
    0. There is no need to cache the disk as it already exists on
    the datastore.

    TrivialFix

    Closes-bug: #1304593
    (cherry picked from commit 9b14ae62a6396a2599c8a2ada1a50e3f69a2eddc)

    Conflicts:
     nova/tests/virt/vmwareapi/test_driver_api.py
     nova/virt/vmwareapi/vmops.py

    Change-Id: Iac75d97f40a1a91b8fa2df7fb4318fc2965fd93a