instance stuck into rebuild state when nova-compute unexpected restart

[jichenjc]

when rebuild an instance, and nova-compute died unexpectedly, then the instance will be in REBUILD state forever unless admin take actions

[root@controller ~]# nova list
+--------------------------------------+--------+---------+------------+-------------+--------------------------------------------+
| ID | Name | Status | Task State | Power State | Networks |
+--------------------------------------+--------+---------+------------+-------------+--------------------------------------------+
| a9dd1fd6-27fb-4128-92e6-93bcab085a98 | test11 | REBUILD | rebuilding | Running

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/86219

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/86219
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2bc0877d3cbe5e6ed9bad0907f61011014b75a2d
Submitter: Jenkins
Branch: master

commit 2bc0877d3cbe5e6ed9bad0907f61011014b75a2d
Author: jichenjc <email address hidden>
Date: Fri Mar 28 04:22:26 2014 +0800

    Update instance state after compute service died for rebuilded instance

    When nova-compute died unexpectedly or rpc message lost unexpectly
    and an rebuild operation is ongoing, the instance will be in REBUILD
    state forever after the nova-compute service restarts.
    Only if admin take actions such as reset its state.
    Like what we did for build instance (general spawn)
    operation, the instance might not be used so it need to be set to ERROR
    state after compute service restarts.

    Change-Id: I37748edb3ca0501b6f2fb41fbd75b7b8aa00d59c
    Closes-Bug: #1304184