'icehouse-compat' broken for nova-compute in Havana

[Russell Bryant]

The following havana-specific commit was merged a while ago:

commit 2c63cae921d024f39f7d14459873d20caa5cf9e0
Author: Russell Bryant <email address hidden>
Date: Thu Dec 5 15:34:58 2013 -0500

    Allow resizes and migrates during live upgrade

    This patch completes the changes needed to havana's compute rpc api to
    allow live upgrades to icehouse. Specifically, these changes are needed
    to allow resizes and migrates to work. Before havana compute nodes get
    put in a mixed environment with icehouse compute nodes, they need to be
    speaking version 3.0 messages.

    Change-Id: If09bd38c9d8c3beb5b95107c497699dec47aa3ef
    Closes-bug: #1258253

Unfortunately, it doesn't work completely as expected. There are some messages that claim to be sending 3.0 messages, but have the data in the wrong format.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/84755

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/84755
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=feedcb240807cdfa354d27ebe3a4b7f416504a62
Submitter: Jenkins
Branch: stable/havana

commit feedcb240807cdfa354d27ebe3a4b7f416504a62
Author: Russell Bryant <email address hidden>
Date: Wed Apr 2 15:22:25 2014 +0000

    Fix 'icehouse-compat' processing for compute rpc

    Commit 2c63cae921d024f39f7d14459873d20caa5cf9e0 added some havana
    specific rpc handling to aid with the live upgrade from havana to
    icehouse. Unfortunately, the processing was broken for some
    methods. It would claim to be sending a '3.0' message, but would
    be sending some of the arguments in an old format, causing some
    methods to break when processed on the remote end.

    This patch fixes up the logic to ensure that if messages are sent as
    '3.0', that the format of the data sent in the message matches.

    Note that this is a stable/havana specific change.

    Change-Id: I54135effe4e083f73cb7d912ac9e82fd182e2b2d
    Closes-bug: #1301436