Remove duplicate code with aggregate filters
Bug #1301340 reported by
Sahid Orentino
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Wishlist
|
Sahid Orentino |
Bug Description
Some filters are using the same logic to handle per-aggregate options. We should create helper to remove this duplicate code and help to implement new filters based on aggregates
Filters that needs to be addressed:
* AggregateRamFilter
* AggregateCoreFi
* AggregateTypeAf
Changed in nova: | |
status: | New → In Progress |
Changed in nova: | |
milestone: | none → juno-1 |
status: | Fix Committed → Fix Released |
Changed in nova: | |
milestone: | juno-1 → 2014.2 |
To post a comment you must log in.
I don't think its just a question of removing duplicated code - doing any DB queries in a filter (like looking up aggregate membership for a host) is a major performance issue at scale as the filter is run once per host.
The aggregate information should be extracted by the host manager and passed into the filters as part of the host state