swap and ephemeral devices defined in the flavor are not created as a block device mapping

[Xavier Queralt]

When booting an instance specifying the swap and/or ephemeral devices, those will be created as a block device mapping in the database together with the image and volumes if present.

If, instead, we rely on libvirt to define the swap and ephemeral devices later from the specified instance type, those devices won't be added to the block device mapping list.

To be consistent and to prevent any errors when trying to guess the device name from the existing block device mappings, we should create a mappings for those devices if present in the instance type. We should create them from the API layer, before validating the block device mappings and only if no swap or ephemeral device are defined by the user.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/83516

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/83805

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/83805
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=38b348ee665af23a6dc324e70664948dd944763f
Submitter: Jenkins
Branch: master

commit 38b348ee665af23a6dc324e70664948dd944763f
Author: Xavier Queralt <email address hidden>
Date: Thu Mar 27 19:19:33 2014 +0100

    Create the image mappings BDMs earlier in the boot

    Refactor the processing of BDMs defined in the image (either as a block
    device mapping in the properties or mappings of blank devices) and move
    it to the same method where the rest of BDMs are processed.

    Partial-bug: #1297325
    Change-Id: Ida0ddb6efcb0014890762df000eaea679f9b1d7b

[Sean Dague (sdague)]

The upstream patches have been stalled and the creator seems not to be working on them. They are available for others to take over.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Joe Gordon (<email address hidden>) on branch: master
Review: https://review.openstack.org/83516
Reason: Patch is stalled waiting for the author, looks like this has been abandoned. Feel free to restore.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/83516
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=7f8128f87f5a2fa93c857295fb7e4163986eda25
Submitter: Jenkins
Branch: master

commit 7f8128f87f5a2fa93c857295fb7e4163986eda25
Author: Xavier Queralt <email address hidden>
Date: Thu Apr 10 13:59:47 2014 +0200

    Add the swap and ephemeral BDMs if needed

    After preparing the block device mapping for creating new instance(s),
    check if any ephemeral and/or a swap disks have been already defined. If
    that is not the case and the instance type requires them, create the
    needed ephemeral and/or swap BDMs.

    Closes-Bug: #1297325
    Related-Bug: #1457527
    Change-Id: I44b30625cf1023d20ebec5e38f46b7b8dab325f6

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/269421

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/269421
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=dd1c3c7561676e7479d4ed60609286ed40f32964
Submitter: Jenkins
Branch: stable/kilo

commit dd1c3c7561676e7479d4ed60609286ed40f32964
Author: Xavier Queralt <email address hidden>
Date: Thu Apr 10 13:59:47 2014 +0200

    Add the swap and ephemeral BDMs if needed

    After preparing the block device mapping for creating new instance(s),
    check if any ephemeral and/or a swap disks have been already defined. If
    that is not the case and the instance type requires them, create the
    needed ephemeral and/or swap BDMs.

    Closes-Bug: #1297325
    Related-Bug: #1457527
    Change-Id: I44b30625cf1023d20ebec5e38f46b7b8dab325f6
    (cherry picked from commit 7f8128f87f5a2fa93c857295fb7e4163986eda25)

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/nova 2015.1.4 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 2015.1.4 release.