NotFound should be insteaded of InstanceNotFound

Bug #1296662 reported by ugvddm
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
ugvddm

Bug Description

 we can see the exception is InstanceNotFound from: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1758,

but, the exception is NotFound in https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/contrib/server_diagnostics.py#L47.

so, the NotFound should be insteaded of InstanceNotFound

ugvddm (271025598-9)
Changed in nova:
assignee: nobody → ugvddm (271025598-9)
Tracy Jones (tjones-i)
tags: added: compute low-hanging-fruit
melanie witt (melwitt)
Changed in nova:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/82964

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/82964
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f0817d3ac11f98c3d518303a50711a6a9c677851
Submitter: Jenkins
Branch: master

commit f0817d3ac11f98c3d518303a50711a6a9c677851
Author: Zhengguang <email address hidden>
Date: Wed Mar 26 09:25:12 2014 +0800

    Change NotFound to InstanceNotFound in server_diagnostics.py

    According to the get() method in nova/compute/api.py,
    the index() method in nova/api/openstack/compute/
    contrib/server_diagnostics.py should catch the
    InstanceNotFound, rather than the NotFound.
    This patch just applies to V2 API, V3 API is already
    catching InstanceNotFound.

    Change-Id: I9e021837b9050dade9af4725a0712f260eac6f7a
    Closes-bug: #1296662

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.