Check parameters before doing boot with eph disk format

[jichenjc]

apparently dummy should not be allowed for eph disk
instead of let boot process check it ,API layer may do a better check on it

[root@controller ~]# nova boot --flavor 21 --key_name mykey --image 43ca519b-979b-4803-95ad-b9f160f1a337 --security_group default --ephemeral size=1,format=dummy test13
+--------------------------------------+--------------------------------------+
| Property | Value |
+--------------------------------------+--------------------------------------+
| OS-EXT-STS:task_state | scheduling |
| image | CirrOS 0.3.1 golden |
| OS-EXT-STS:vm_state | building |
| OS-EXT-SRV-ATTR:instance_name | instance-00000047 |
| OS-SRV-USG:launched_at | None |

[Christopher Yeoh (cyeoh-0)]

Hrm aren't the valid values going to be rather dependent on the backend implementation?

[jichenjc (jichenjc)]

it might be dependant on the backend (not sure about others, but at least libvirt should only support ext family now)

we might add a definition list to check whether input belongs to the list or not to avoid additional work for low layer check

[jichenjc (jichenjc)]

according to review comments, this defect is correctly described

it should be checked at virt layer instead of API layer

so will going to do the check at virt layer

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/99880

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/100451

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/99880
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=89cd2f9a4dc4c12aaf0ce2ed2c492ad60fd1f6d7
Submitter: Jenkins
Branch: master

commit 89cd2f9a4dc4c12aaf0ce2ed2c492ad60fd1f6d7
Author: jichenjc <email address hidden>
Date: Mon Jun 9 04:13:18 2014 +0800

    Add supported file system type check at virt layer

    Currently nova doesn't check whether the file system type is supported
    by virt layer(hypervisor) before use it. This patch adds current
    support file system type definition then create a default check
    function at virt layer. Following patches will do the real check
    in different driver such as libvirt.

    Change-Id: Ie4d876a48b36c1a53b171dd521bdeef868a31486
    Partial-Bug: #1293880

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/100451
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b1cde33175bc555e1af822894e8c3f981fbb8ef6
Submitter: Jenkins
Branch: master

commit b1cde33175bc555e1af822894e8c3f981fbb8ef6
Author: jichenjc <email address hidden>
Date: Thu Jun 19 17:44:31 2014 +0800

    check ephemeral disk format at libvirt before use

    Add ephemeral disk format at libvirt. There is no check before
    so it will be used directly. This patch adds valid check function
    and validate it before eph disk was used in virt layer.

    Change-Id: I1934573e79f126e725cef4848b15c11a595161c9
    Closes-Bug: #1293880