libvirt inject_data assumes instance with kernel_id doesn't contain a partition table

Bug #1290455 reported by Matthew Booth on 2014-03-10
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Wishlist
Unassigned

Bug Description

libvirt/driver.py passes partition=None to disk.inject_data() for any instance with kernel_id set. partition=None means that inject_data will attempt to mount the whole image, i.e. assuming there is no partition table. While this may be true for EC2, it is not safe to assume that Xen images don't contain partition tables. This should check something more directly related to the disk image. In fact, ideally it would leave it up to libguestfs to work it out, as libguestfs is very good at this.

sahid (sahid-ferdjaoui) on 2014-03-11
tags: added: libvirt
Changed in nova:
status: New → Confirmed
sahid (sahid-ferdjaoui) on 2014-03-11
Changed in nova:
importance: Undecided → Wishlist
Changed in nova:
assignee: nobody → Saranya Pandian (saranya-pandian)
Changed in nova:
assignee: Saranya Pandian (saranya-pandian) → nobody

This wishlist bug has been open a year without any activity. I'm going to move it to "Opinion / Wishlist", which is an easily-obtainable queue of older requests that have come on.

In case you want to work on that, consider writing a blueprints [1] and spec [2]. I'll recommend to read [3] if not yet done. The effort to implement the requested feature is then driven only by the blueprint (and spec).

References:
[1] https://blueprints.launchpad.net/nova/
[2] https://github.com/openstack/nova-specs
[3] https://wiki.openstack.org/wiki/Blueprints

Changed in nova:
status: Confirmed → Opinion

Fix proposed to branch: master
Review: https://review.openstack.org/330140

Changed in nova:
assignee: nobody → Alexandru Avadanii (alexandru-avadanii)
status: Opinion → In Progress

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/330140
Reason: This review is > 6 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Sean Dague (sdague) wrote :

There are no currently open reviews on this bug, changing
the status back to the previous state and unassigning. If
there are active reviews related to this bug, please include
links in comments.

Changed in nova:
status: In Progress → Opinion
assignee: Alexandru Avadanii (alexandru-avadanii) → nobody
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers