Duplicate security group name cause fail to start instance

[Lee Li]

When create a security group, the duplicate name is allowed.
In create a instance, duplicate sg name will cause exception and the instance will be started fail. So the duplicate name of sg should be not allowed.

In nova.network.neutronv2.API:allocate_for_instance
for security_group in security_groups:
    name_match = None
    uuid_match = None
    for user_security_group in user_security_groups:
        if user_security_group['name'] == security_group: # if have duplicate sg name, the name_match will not be None for the second matching.
            if name_match:
                raise exception.NoUniqueMatch(
                    _("Multiple security groups found matching"
                       " '%s'. Use an ID to be more specific.") %
                    security_group)

            name_match = user_security_group['id']
        if user_security_group['id'] == security_group:
            uuid_match = user_security_group['id']

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/79270

[yong sheng gong (gongysh)]

It reads well: please use ID in this case!

[yong sheng gong (gongysh)]

If the ID will cover this case, I think the bug is invalid!

[Xurong Yang (idopra)]

It should be using UUID instead of 'name' such as network_id port_id as name(not the key) can't differentiate security groups. so i think we should fix it in nova.

[Tracy Jones (tjones-i)]

this has not been touched in a long time and the patches are abandoned. Please set back to in progress if you start to work on it

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/310683

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/217292
Reason: This code hasn't been updated in a long time, and is in merge conflict. I am going to abandon this review, but feel free to restore it if you're still working on this.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/310683
Reason: This patch has been sitting unchanged for more than 12 weeks. I am therefore going to abandon it to keep the nova review queue sane. Please feel free to restore the change if you're still working on it.

[Anusha Unnam (anusha-unnam)]

Since the patch is abondoned removing the assignee. Lee if you still want to work on this bug please reassign it to yourself and push a patch for it.