resize an instance should not set state to error if no host found

Bug #1289174 reported by jichenjc
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Invalid
Undecided
jichenjc

Bug Description

In resize operation there is code looks like:

if not instance['host']:
    self._set_instance_error_state(context, instance['uuid'])
    msg = _('Instance has no source host')
    raise exception.MigrationError(msg)

same_host = instance['host'] == self.host
if same_host and not CONF.allow_resize_to_same_host:
    self._set_instance_error_state(context, instance['uuid'])
    msg = _('destination same as source!')
    raise exception.MigrationError(msg)

however, it's not reasonable to set an instance to ERROR state if we can't find a host when we try to resize an instance
we'd better keep the instance in ACTIVE state and report there is no host

jichenjc (jichenjc)
Changed in nova:
assignee: nobody → jichencom (jichenjc)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/78897

Changed in nova:
status: New → In Progress
Revision history for this message
Tracy Jones (tjones-i) wrote :

this has not been touched in a long time and the patches are abandoned. Please set back to in progress if you start to work on it

Changed in nova:
status: In Progress → Triaged
Revision history for this message
jichenjc (jichenjc) wrote :

due to remove comments, abandon

Changed in nova:
status: Triaged → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.