VMware: vim.get_soap_url improper IPv6 address

[Eric Brown]

The vim.get_soap_url function incorrectly builds an IPv6 address using hostname/IP and port.

https://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/vim.py#L151

The result of this line would create an address as follows:
https://[2001:db8:85a3:8d3:1319:8a2e:370:7348:443]/sdk

Ports should be outside the square brackets, not inside, as follows:

https://[2001:db8:85a3:8d3:1319:8a2e:370:7348]:443/sdk

For reference see: http://en.wikipedia.org/wiki/IPv6_address section Literal IPv6 addresses in network resource identifiers

[Eric Brown (ericwb)]

Python 3.3 adds a nice convenience class to handle IP addresses.
http://docs.python.org/3.3/library/ipaddress

[Eric Brown (ericwb)]

After further research, a port should not be specified as part of host_name. First of all, in the case of IPv6, you can't tell if there is a port specified because IPv6 addresses use ':' as part of the address. Secondly, the host_name is comes from the nova.conf vmware.host_ip which does not indicate a port can be specified. So I'll update the comments in vim.py.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/78455

[Andrew Laski (alaski)]

The fix is still under review.

[Davanum Srinivas (DIMS) (dims-v)]

We need to fix oslo.vmware as well.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/78455
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4640542cc502a442d4807822d75d3fa3eff0a33b
Submitter: Jenkins
Branch: master

commit 4640542cc502a442d4807822d75d3fa3eff0a33b
Author: Eric Brown <email address hidden>
Date: Wed Mar 5 18:37:00 2014 -0500

    VMware: Fix usage of an alternate ESX/vCenter port

    IPv6 addresses use square brackets to delimit address vs. port.
    A comment in vim.py file incorrectly states the host and port can be
    specified as host:port. According to nova.conf, port isn't
    even part of the host option.

    This patch will create a separate port option to nova.conf instead
    of allowing the port to be part of the host_ip option.

    DocImpact: new host_port option added to nova.conf
    Change-Id: Iebd415b5b3a9d2be42861220366135d2cb57b14d
    Closes-bug: #1287292

[Davanum Srinivas (DIMS) (dims-v)]

Here's the oslo.vmware review : https://review.openstack.org/#/c/91573/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/91573
Committed: https://git.openstack.org/cgit/openstack/oslo.vmware/commit/?id=a76bd253fb4fa54c72d3440f2345642b209b5f41
Submitter: Jenkins
Branch: master

commit a76bd253fb4fa54c72d3440f2345642b209b5f41
Author: Davanum Srinivas <email address hidden>
Date: Thu May 1 10:05:41 2014 -0400

    Support for IPv6 and Non-standard ports

    IPv6 urls are formatted with '[' and ']' around the host and
    the port actually shows up after the trailing ']' as well. So
    we need to allow for better support for both ipv6 and non
    standard urls when dealing with both SOAP and WSDL urls.

    Examples:
       https://[fd2e:1201:1d9f:0:8886:78e0:38cd:cb03]/sdk
       https://[::1]:9443/sdk/

    Closes-Bug: #1287292

    Change-Id: I84ab38087ea77a30f6082d8c3fae0341e3371a78