rootrwrap.conf documents incorrect syslog facility settings

Bug #1280879 reported by John Stanford
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
shihanzhang
OpenStack Compute (nova)
Fix Released
Low
John Stanford
neutron
Fix Released
Wishlist
shihanzhang

Bug Description

In /etc/nova/rootwrap.conf, the following comment contains incorrect "valid values":

# Which syslog facility to use.
# Valid values include auth, authpriv, syslog, user0, user1...
# Default value is 'syslog'
#syslog_log_facility=syslog

The user0, user1 settings are invalid. Valid values include "local0, local1".

Changed in nova:
assignee: nobody → John Stanford (e-john-6)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/73883

Changed in nova:
status: New → In Progress
Changed in neutron:
assignee: nobody → shihanzhang (shihanzhang)
Changed in cinder:
assignee: nobody → shihanzhang (shihanzhang)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/73958

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/74220

Changed in neutron:
status: New → In Progress
Changed in neutron:
importance: Undecided → Wishlist
milestone: none → icehouse-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/74220
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a5a8e2db49aa1a12ffc968fb23913f7eeade69a3
Submitter: Jenkins
Branch: master

commit a5a8e2db49aa1a12ffc968fb23913f7eeade69a3
Author: shihanzhang <email address hidden>
Date: Tue Feb 18 09:50:57 2014 +0800

    Fix invalid facilities documented in rootwrap.conf

    The values user0 and user1 do not map to valid facility values.
    local1, etc. Using user0 results in a pri value that does not map
    back to a facility of the same name in syslog.

    RFC5424 suggest values values of local0 through local7. Setting
    syslog_log_facility to one of those values results in a message with a
    priority that can be mapped back to the original string value.

    This fix adjusts the comment in rootwrap.conf to suggest the local
    prefix instead of the user prefix.

    Change-Id: I835ad17c817b8623e382368b39b06944470be480
    Closes-bug: #1280879

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/73958
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=5074cf5f574c94bd1a11b143bed9a6b22fa01ec5
Submitter: Jenkins
Branch: master

commit 5074cf5f574c94bd1a11b143bed9a6b22fa01ec5
Author: shihanzhang <email address hidden>
Date: Mon Feb 17 15:51:49 2014 +0800

    Fix invalid facilities documented in rootwrap.conf

    The values user0 and user1 do not map to valid facility values.
    local1, etc. Using user0 results in a pri value that does not map
    back to a facility of the same name in syslog.

    RFC5424 suggest values values of local0 through local7. Setting
    syslog_log_facility to one of those values results in a message with a
    priority that can be mapped back to the original string value.

    This fix adjusts the comment in rootwrap.conf to suggest the local
    prefix instead of the user prefix.

    Change-Id: I1c1233ab2386994672d22341fbe3e097409dbcbc
    Closes-bug: #1280879

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → icehouse-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Mark McLoughlin (markmc)
Changed in nova:
importance: Undecided → Low
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/73883
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=9137786317a49f0a54655e0821b38b9f9ce605a8
Submitter: Jenkins
Branch: master

commit 9137786317a49f0a54655e0821b38b9f9ce605a8
Author: John Stanford <email address hidden>
Date: Sun Feb 16 12:58:42 2014 -0800

    Fix invalid facilities documented in rootwrap.conf

    The values user0 and user1 do not map to valid facility values.
    local1, etc. Using user0 results in a pri value that does not map
    back to a facility of the same name in syslog.

    RFC5424 suggest values values of local0 through local7. Setting
    syslog_log_facility to one of those values results in a message with a
    priority that can be mapped back to the original string value.

    This fix adjusts the comment in rootwrap.conf to suggest the local
    prefix instead of the user prefix.

    Closes-Bug #1280879

    Change-Id: Ibefffb5619641b75b4f8ac8ce8112a34cf03f0ce

Thierry Carrez (ttx)
Changed in cinder:
milestone: icehouse-3 → 2014.1
Thierry Carrez (ttx)
Changed in neutron:
milestone: icehouse-3 → 2014.1
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.