VolumeOpsTestCase class is incorrectly inheriting from HyperVAPITestCase

Bug #1280379 reported by Alessandro Pilotti
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Alessandro Pilotti

Bug Description

The VolumeOpsTestCase class in test_hypervapi.py inherits from HyperVAPITestCase, resulting in all the tests from the base class being executed twice.

The patch that introduced the VolumeOpsTestCase is here:

https://github.com/openstack/nova/commit/d143540ad1b69ec93c2b7bfadd1f654c4d8c7a34

Tags: hyper-v
tags: added: hyper-v
Changed in nova:
status: New → In Progress
Changed in nova:
importance: Undecided → Medium
assignee: nobody → Alessandro Pilotti (alexpilotti)
description: updated
summary: - volumeops are incorrectly inheriting from HyperVAPITestCase
+ VolumeOpsTestCase class is incorrectly inheriting from HyperVAPITestCase
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/73671

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/73671
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c1a64c94ef848f825e6a36581814511a81945428
Submitter: Jenkins
Branch: master

commit c1a64c94ef848f825e6a36581814511a81945428
Author: Alessandro Pilotti <email address hidden>
Date: Fri Feb 14 19:22:35 2014 +0200

    Fixes the Hyper-V VolumeOpsTestCase base class

    The VolumeOpsTestCase base class inherits incorrectly from
    HyperVAPITestCase, with the unwanted side effect of executing all
    base class tests as well.

    This patch generalizes a common base class from HyperVAPITestCase
    and fixes the inheritance issue.

    Closes-Bug: #1280379

    Change-Id: Ic81beb8397138c16c8d2d88a9c9d05d2b76e0e83

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → icehouse-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.