--ephemeral option's format was not correctly set

[jichenjc]

novaclient has following option

--ephemeral size=<size>[,format=<format>]
                        Create and attach a local ephemeral block device of
                        <size> GB and format it to <format>.

so
nova boot --flavor 21 --key_name mykey --image 43ca519b-979b-4803-95ad-b9f160f1a337 --security_group default --ephemeral size=1 --ephemeral size=2,format=ext4 test12

should work

however, the eph disk created is ext3 ,ignore the option specified by format

[Maithem (maithem)]

Which driver are you using libvirt?

[Xavier Queralt (xqueralt-deactivatedaccount)]

Looks like most of the drivers (I've just checked xen and libvirt) rely on the value of 'default_ephemeral_format' (libvirt defaults to ext3 if not set). I think that if the BDM specifies a format, the driver should use it when calling the mkfs method.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/84338

[OpenStack Infra (hudson-openstack)]

Change abandoned by jichenjc (<email address hidden>) on branch: master
Review: https://review.openstack.org/84338
Reason: use another patch

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/100473

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/100473
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5856c3e585891103767eda87035dee8ecaee32ab
Submitter: Jenkins
Branch: master

commit 5856c3e585891103767eda87035dee8ecaee32ab
Author: jichenjc <email address hidden>
Date: Thu Jun 19 18:07:52 2014 +0800

    Format eph disk with specified format in libvirt

    novaclient has following command parameters:
    --ephemeral size=<size>[,format=<format>]
    Create and attach a local ephemeral block device of
    <size> GB and format it to <format>.

    so mkfs should use the specified format instead of using
    default format.

    Change-Id: I7a8753284d7b1da1a1203e85b430bd0c5012937a
    Closes-Bug: #1280132