Strings passed to InvalidAggregateAction should be translated

Bug #1278736 reported by Mark McLoughlin
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
jichenjc

Bug Description

InvalidAggregateAction .looks like:

 class InvalidAggregateAction(Invalid):
     msg_fmt = _("Cannot perform action '%(action)s' on aggregate "
     "%(aggregate_id)s. Reason: %(reason)s.")

The values for action are:

  delete
  add_host_to_aggregate
  update aggregate
  update aggregate metadata

Also we use 'not empty' untranslated as a reason string in one place

We should standardize these strings a little more and always translate them

jichenjc (jichenjc)
Changed in nova:
assignee: nobody → jichenjc (jichenjc)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/101439

Changed in nova:
status: Triaged → In Progress
Revision history for this message
Sean Dague (sdague) wrote :

stalled until kilo

Changed in nova:
status: In Progress → Confirmed
assignee: jichenjc (jichenjc) → nobody
jichenjc (jichenjc)
Changed in nova:
assignee: nobody → jichenjc (jichenjc)
Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/101439
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d330f56ec45ba6b1101eb379523bc4fca98b0f0c
Submitter: Jenkins
Branch: master

commit d330f56ec45ba6b1101eb379523bc4fca98b0f0c
Author: jichenjc <email address hidden>
Date: Mon Oct 27 07:38:47 2014 +0800

    Correct InvalidAggregateAction translation&format.

    InvalidAggregateAction .looks like:
     class InvalidAggregateAction(Invalid):
         msg_fmt = _("Cannot perform action '%(action)s' on aggregate "
         "%(aggregate_id)s. Reason: %(reason)s.")

    The values for action are not well formed and reason are not translated.
    This patch fixs those problems

    Change-Id: I9ed20badde8a38eb71c5f121f30e4d54ad50022e
    Closes-Bug: #1278736

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.