VMware: exception handling throws error - AttributeError: 'NoneType' object has no attribute 'getChildren'

[Gary Kotton]

[req-83b880af-7ed2-417f-8d91-ae9b7d624be1 FixedIPsTestJson-1652350262 FixedIPsTestJson-1562534047] In vmwareapi: _call_method (session=52e6b7a6-4745-7303-17f1-52ed4da676a8)
Traceback (most recent call last):
  File "/opt/stack/nova/nova/virt/vmwareapi/driver.py", line 817, in _call_method
    return temp_module(*args, **kwargs)
  File "/opt/stack/nova/nova/virt/vmwareapi/vim.py", line 197, in vim_request_handler
    for child in detail.getChildren():
AttributeError: 'NoneType' object has no attribute 'getChildren'

[Gary Kotton (garyk)]

Fixed as part of https://review.openstack.org/#/c/70137/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/70137
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=fb12fa03ad21c4c8924175ae77bc6bd30139f089
Submitter: Jenkins
Branch: master

commit fb12fa03ad21c4c8924175ae77bc6bd30139f089
Author: Gary Kotton <email address hidden>
Date: Thu Jan 30 07:10:14 2014 -0800

    VMware: raise more specific exceptions

    In certain cases the exception handling for backend errors
    would be handled too broadly. This patch elevates the backend exception
    to the application so that it can treat specific errors.

    In the application we can now handle the following specific exceptions:
     - FileAlreadyExists - for example when moving a directory to a directory
                           that already exists
     - InvalidProperty - for example when using neutron and opaque networks
                         are not supported
     - AlreadyExists - for example a port group already exists
     - NotAuthenticated - for example the operation is denied as because a
                          session is not established

    Related-Bug: #1266579
    Related-Bug: #1266580
    Closes-bug: #1276539

    Co-authored-by: Matthew Booth <email address hidden>
    Change-Id: I0873f570d97345208c8d9b5bcbb5a980a7a58f9d