PCI device object should be purely DB layer

Bug #1273852 reported by jiang, yunhong
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Wishlist
jiang, yunhong

Bug Description

Currently the PCI device object includes a lot of function like alloc/free/claim etc. However, the NovaObject should not be used this way, and it makes the PCI device object really different with other NovaObject implementation.

We should keep the PCI device object as simple data access, and keep those method to separated functions.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/69731

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/69732

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/69733

Matt Riedemann (mriedem)
Changed in nova:
assignee: nobody → jiang, yunhong (yunhong-jiang)
status: New → In Progress
Matt Riedemann (mriedem)
tags: added: pci unified-objects
Changed in nova:
importance: Undecided → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/69731
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ba637a177aa5bdefa4b6db9a062e8c0ece0b597b
Submitter: Jenkins
Branch: master

commit ba637a177aa5bdefa4b6db9a062e8c0ece0b597b
Author: Yunhong Jiang <email address hidden>
Date: Mon Jan 27 14:50:33 2014 -0800

    Separate the PCI device object handling code

    Currently the PCI device object includes several functions like
    alloc/free/claim etc. However, the NovaObject should not be used
    this way, and it makes the PCI device object really different
    with other NovaObject implementations.

    This patch duplicates the PCI device handling code as separated
    functions. No logic changes but simply code copy. A later patch
    will delete the code at PciDevice object.

    Closes-Bug: #1273852

    Change-Id: I2389d29218d8619998f8df973004af004e8b1b76

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/69732
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c42a22a07925e21770adf486c1904eacdff308ec
Submitter: Jenkins
Branch: master

commit c42a22a07925e21770adf486c1904eacdff308ec
Author: Yunhong Jiang <email address hidden>
Date: Mon Jan 27 17:59:00 2014 -0800

    Use new pci device handling code in pci_manager

    As we remove some pci device method from PCI device object,
    update the pci manager accordingly.

    Closes-Bug: #1273852

    Change-Id: I0ec0e7b03625888a207918816b6e2d537b6d7d54

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/69733
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=60ca9548905b58cea67776a71864486bfd1d69c7
Submitter: Jenkins
Branch: master

commit 60ca9548905b58cea67776a71864486bfd1d69c7
Author: Yunhong Jiang <email address hidden>
Date: Tue Jan 28 09:59:53 2014 -0800

    Remove the device handling from pci device object

    Remove the device handling code at pci device object to make
    it similar to other NovaObject.

    Remove some usage in test cases.

    Closes-Bug: #1273852

    Change-Id: I4487ae0b36de18365d12593f480c05f0fe726769

Changed in nova:
milestone: none → juno-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.