The pci manager try to modify the pci device list

Bug #1273803 reported by jiang, yunhong
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Wishlist
jiang, yunhong

Bug Description

Currently the ObjectList is mostly immutable, i.e. although the items in the list is changable, but the list itself should not be add or remove.

However the PCI manager use a ObjectList to track all the devices in the host and may add/remove, this is not correct. We should not use the Object List but a simple list to track all the devices.

Changed in nova:
assignee: nobody → jiang, yunhong (yunhong-jiang)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/69730

Matt Riedemann (mriedem)
Changed in nova:
status: New → In Progress
tags: added: pci unified-objects
Changed in nova:
importance: Undecided → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/69730
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=81f9256747377f1b9488b407a2f33d251ffd1d8f
Submitter: Jenkins
Branch: master

commit 81f9256747377f1b9488b407a2f33d251ffd1d8f
Author: Yunhong Jiang <email address hidden>
Date: Mon Jan 27 17:18:46 2014 -0800

    Remove PciDeviceList usage in pci manager

    Pci manager keeps a PciDeviceList and even try to append
    object to the list. This is not correct, as the ObjectList
    is designed as immutable, although the objects in the list is
    mutable. We should simply use a list to keep devices.

    Closes-Bug: #1273803

    Change-Id: Ie80b6f5f47a1d2d2e20aadb4779be142c17b5b38

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.