OpenStack Compute (nova)

improper use of mock with stevedore in tests

Bug #1273451 reported by Doug Hellmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Emily Hugenbruch
OpenStack Compute (nova) 2015.1.0 "kilo"

Bug Description

The tests in nova/tests/test_hook.py are mocking a private part of the stevedore API (_load_plugins) instead of using ExtensionManager.make_test_instance() to create a test version of an ExtensionManager and passing that somewhere instead.

See https://review.openstack.org/#/c/69475/1 as a first-pass work-around.

See original description
Doug Hellmann (doug-hellmann)
description: updated
Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

This one isn't a duplicate. The other bug is for tracking a short term fix and any gate failures until that lands. This bug is to actually fix nova's use of mock with stevedore in the test suite so it no longer mocks out a private method.

Matt Riedemann (mriedem)
tags: added: testing
Revision history for this message
Joe Gordon (jogo) wrote :

Removing the testing tag since this isn't a testing/gate issue anymore this is the bug to fix nova's use of mock with stevadore

tags: removed: testing
Changed in nova:
status: New → Incomplete
status: Incomplete → Confirmed
importance: Undecided → Low
Emily Hugenbruch (ekhugen)
Changed in nova:
assignee: nobody → Emily Hugenbruch (ekhugen)
Davanum Srinivas (DIMS) (dims-v)
Changed in nova:
status: Confirmed → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.