compute.instance.{create,delete}.{start,end} notification event types do not include audit_period_{beginning,ending} fields

[Matthew Gilliard]

Currently there is inconsistency in what fields are present in some instance-lifecycle notifications. `compute.instance.update` includes fields `audit_period_beginning` and `audit_period_ending` but `compute.instance.{create,delete}.{start,end}` event types do not, and we are forced to assume that the the audit period can be inferred from the timestamp of the notification.

This causes billing teams problems because of:
  - inconsistency between nova events
  - inconsistency between nova and other OS components

I propose adding the audit_period_{beginning,ending} fields to those messages as a fix.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/68159

[Andrea Rosa (andrea-rosa-m)]

Hi Matthew,

I am not fully convinced that we should include audit_period for compute.instance.{create,delete}.{start,end} messages.
The audit period is supposed to be used with periodic tasks, am I get it right?
I can't see the point to not use the timestamp of the messages.

Probably I am missing some points, hopefully someone else with more info about that can comment here or on your patch.
Thanks

[Joe Gordon (jogo)]

Is this bug still valid? The patch was abandoned.

[Matthew Gilliard (matthew-gilliard-u)]

Thanks for the reminder Joe - this is not really a bug and the patch was unnecessary as Andrea Rosa points out.