Calls to get_vifs_by_instance are not implemented when using neutron

[Brent Eagles]

The get_vifs_by_instance() call in the nova.network.neutronv2.api module is not implemented.

[Matt Riedemann (mriedem)]

Not sure if this is intentional or not.

[Gary Kotton (garyk)]

Hi,
Please see:

    def get_vif_by_mac_address(self, context, mac_address):
        """Returns the vifs record for the mac_address."""
        # NOTE(vish): This is no longer used but can't be removed until
        # we major version the network_rpcapi to 2.0.
        # NOTE(russellb) No need to object-ify this since
        # get_vifs_by_instance() is unused and set to be removed.
        vif = self.db.virtual_interface_get_by_address(context,
                                                        mac_address)
        if vif.get('network_id') is not None:
            network = self._get_network_by_id(context, vif['network_id'])
            vif['net_uuid'] = network['uuid']
        return vif

I do not think that this is a bug

Thanks
Gary

[Brent Eagles (beagles)]

The above comment appears in code that is in internal RPC server, not the nova-network API implementation. It seems reasonable that we should implement it.

[Aaron Rosen (arosen)]

Hrm this method is still used in: api/openstack/compute/contrib/extended_virtual_interfaces_net.py

[Jakub Libosvar (libosvar)]

Proposed patch: https://review.openstack.org/#/c/98386

[OpenStack Infra (hudson-openstack)]

Change abandoned by Jakub Libosvar (<email address hidden>) on branch: master
Review: https://review.openstack.org/98386
Reason: Abandoning per garyk's comment.

[Brent Eagles (beagles)]

Gary's comment only applies to the manager implementations in nova, not the API and this code is called from contrib.

Since this throws a NotImplemented when neutron is used, what is it we want to do here:

- consider it a "known issue" and live with the neutron case not working
- get rid of the functionality across the board so it isn't relevant anymore