Calls to get_vifs_by_instance are not implemented when using neutron

Bug #1269061 reported by Brent Eagles
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Won't Fix
Undecided
Jakub Libosvar

Bug Description

The get_vifs_by_instance() call in the nova.network.neutronv2.api module is not implemented.

Revision history for this message
Matt Riedemann (mriedem) wrote :

Not sure if this is intentional or not.

tags: added: network
Revision history for this message
Gary Kotton (garyk) wrote :

Hi,
Please see:

    def get_vif_by_mac_address(self, context, mac_address):
        """Returns the vifs record for the mac_address."""
        # NOTE(vish): This is no longer used but can't be removed until
        # we major version the network_rpcapi to 2.0.
        # NOTE(russellb) No need to object-ify this since
        # get_vifs_by_instance() is unused and set to be removed.
        vif = self.db.virtual_interface_get_by_address(context,
                                                        mac_address)
        if vif.get('network_id') is not None:
            network = self._get_network_by_id(context, vif['network_id'])
            vif['net_uuid'] = network['uuid']
        return vif

I do not think that this is a bug

Thanks
Gary

Changed in nova:
status: New → Incomplete
Revision history for this message
Brent Eagles (beagles) wrote :

The above comment appears in code that is in internal RPC server, not the nova-network API implementation. It seems reasonable that we should implement it.

Revision history for this message
Aaron Rosen (arosen) wrote :

Hrm this method is still used in: api/openstack/compute/contrib/extended_virtual_interfaces_net.py

no longer affects: neutron
Changed in nova:
assignee: nobody → Eugene Nikanorov (enikanorov)
Revision history for this message
Jakub Libosvar (libosvar) wrote :
Changed in nova:
assignee: Eugene Nikanorov (enikanorov) → Jakub Libosvar (libosvar)
status: Incomplete → In Progress
Brent Eagles (beagles)
tags: added: neutron
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Jakub Libosvar (<email address hidden>) on branch: master
Review: https://review.openstack.org/98386
Reason: Abandoning per garyk's comment.

Changed in nova:
status: In Progress → Won't Fix
Revision history for this message
Brent Eagles (beagles) wrote :

Gary's comment only applies to the manager implementations in nova, not the API and this code is called from contrib.

Since this throws a NotImplemented when neutron is used, what is it we want to do here:

- consider it a "known issue" and live with the neutron case not working
- get rid of the functionality across the board so it isn't relevant anymore

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers